From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19563 invoked by alias); 8 Mar 2010 04:54:38 -0000 Received: (qmail 19551 invoked by uid 22791); 8 Mar 2010 04:54:36 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Mar 2010 04:54:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DD65D2BAB35; Sun, 7 Mar 2010 23:54:29 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id S+oEsD12wc5C; Sun, 7 Mar 2010 23:54:29 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 63F9C2BAB30; Sun, 7 Mar 2010 23:54:29 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 72A74F5894; Mon, 8 Mar 2010 08:54:15 +0400 (RET) Date: Mon, 08 Mar 2010 04:54:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org, Daniel Jacobowitz Subject: Re: Automatically replace shared library extensions on Symbian Message-ID: <20100308045415.GB3081@adacore.com> References: <201003051846.23406.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201003051846.23406.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00293.txt.bz2 > What do you think of this? A gdbarch setting sounds indeed better to me, as the debugger is then doing the right thing automatically. > 2010-03-05 Daniel Jacobowitz > Pedro Alves > > gdb/ > * solib.c (solib_find): Replace extension if > solib_symbols_extension set in the target gdbarch. > * arm-symbian-tdep.c (arm_symbian_init_abi): Set > solib_symbols_extension to "sym". > * gdbarch.sh (solib_symbols_extension): New variable. > (pstring): New function. > * gdbarch.h, gdbarch.c: Regenerate. No real comment on the code, except maybe: > + > +# If non-empty, this is a file extension that will be opened in place > +# of the file extension reported by the shared library list. > +v:const char *:solib_symbols_extension:::::::pstring (gdbarch->solib_symbols_extension) Would you mind expanding the commend above to explain that Symbian OS is one example where this can be useful, and why? Basically, the current description is a bit short, and I also found the paragraph describing what happens on Symbian to be very interesting and useful... Another option for preserving the description of what happens on Symbian OS is to provide it at the location where you call set_solib_symbols_extension, but it might be more difficult for someone working on a different architecture having the same problem and looking for the gdbarch method that would allow him to solve his problem? -- Joel