From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10299 invoked by alias); 6 Mar 2010 04:05:53 -0000 Received: (qmail 10289 invoked by uid 22791); 6 Mar 2010 04:05:52 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 06 Mar 2010 04:05:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B8E9F2BABDC; Fri, 5 Mar 2010 23:05:46 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DJ8QiWZhLfzh; Fri, 5 Mar 2010 23:05:46 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 439A42BAB9F; Fri, 5 Mar 2010 23:05:46 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 3BF7DF5894; Sat, 6 Mar 2010 08:05:35 +0400 (RET) Date: Sat, 06 Mar 2010 04:05:00 -0000 From: Joel Brobecker To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [RFC] remote-mips.c: Don't error out when a memory read fails Message-ID: <20100306040535.GN2832@adacore.com> References: <20100305154846.29fab2c4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100305154846.29fab2c4@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00253.txt.bz2 > * remote-mips.c (mips_fetch_word): Add new parameter, `valp'. > Change return value to int. Store value fetched in location > addressed by `val'. Use function's return value as success > or failure indicator. Adjust all callers. Looks good to me. > +static int > +mips_fetch_word (CORE_ADDR addr, unsigned int *valp) > { > unsigned int val; I think that this variable is no longer used? -- Joel