From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1697 invoked by alias); 5 Mar 2010 04:58:51 -0000 Received: (qmail 1688 invoked by uid 22791); 5 Mar 2010 04:58:49 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Mar 2010 04:58:45 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 195942BABF6; Thu, 4 Mar 2010 23:58:44 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id iqrwGUljDeR9; Thu, 4 Mar 2010 23:58:44 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 95C422BABDD; Thu, 4 Mar 2010 23:58:43 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 1EE7DF5894; Fri, 5 Mar 2010 08:58:34 +0400 (RET) Date: Fri, 05 Mar 2010 04:58:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: FYI: DW_FORM_ref_addr -vs- DWARF 3 Message-ID: <20100305045834.GL2832@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00225.txt.bz2 Hi Tom, > 2010-03-04 Tom Tromey > > * dwarf2read.c (skip_one_die) : Use offset size > in DWARF 3 and later. > (read_attribute_value) : Likewise. This patch looks fine to me for head and branch. I don't know which version I prefer, between Jim's and yours, but yours is smaller :). -- Joel