Re: PING: PATCH: Support "ah", "bh", "ch", "dh" in amd64

H.J. Lu
2010-04-01T19:43:20Z

On Thu, Apr 1, 2010 at 12:20 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>> Date: Thu, 1 Apr 2010 06:13:39 -0700
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>>
>> On Wed, Mar 03, 2010 at 12:53:13PM -0800, H.J. Lu wrote:
>> > Hi,
>> >
>> > AMD64 can access "ah", "bh", "ch", "dh".  I missed them in my x86
>> > pseudo register support.  This patch adds them. OK to install?
>> >
>> > Thanks.
>> >
>> >
>> > H.J.
>> > ---
>> > gdb/
>> >
>> > 2010-03-03  H.J. Lu  <hongjiu.lu@intel.com>
>> >
>> >     * amd64-tdep.c (amd64_byte_names): Add "ah", "bh", "ch", "dh".
>> >     (amd64_pseudo_register_read): Handle "ah", "bh", "ch", "dh".
>> >     (amd64_pseudo_register_write): Likewise.
>> >     (amd64_init_abi): Set num_byte_regs to 20.
>> >
>> > gdb/testsuite/
>> >
>> > 2010-03-03  H.J. Lu  <hongjiu.lu@intel.com>
>> >
>> >     * gdb.arch/amd64-byte.exp: Check "ah", "bh", "ch", "dh".
>> >
>>
>> PING.
>
> Sorry; this dropped off my radar;
>
> +      if (gpnum >= 16)
>
> can you replace that magic constant with a proper #define?
>

The updated on is at

http://sourceware.org/ml/gdb-patches/2010-04/msg00024.html

--
H.J.