From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31668 invoked by alias); 3 Mar 2010 18:22:18 -0000 Received: (qmail 31644 invoked by uid 22791); 3 Mar 2010 18:22:16 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Wed, 03 Mar 2010 18:22:12 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 17EFA6D42F5; Wed, 3 Mar 2010 19:22:10 +0100 (CET) Date: Wed, 03 Mar 2010 18:22:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for Cygwin and MingW builds Message-ID: <20100303182210.GW17293@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org, Tom Tromey References: <20100301173054.GD5683@calimero.vinschen.de> <20100301193126.GA9416@caradoc.them.org> <20100303170645.GA23545@caradoc.them.org> <20100303172217.GR17293@calimero.vinschen.de> <20100303173307.GA25653@caradoc.them.org> <20100303180044.GU17293@calimero.vinschen.de> <20100303180506.GA14979@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100303180506.GA14979@caradoc.them.org> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00115.txt.bz2 On Mar 3 13:05, Daniel Jacobowitz wrote: > On Wed, Mar 03, 2010 at 07:00:44PM +0100, Corinna Vinschen wrote: > > I didn't say anything against doing it right. But this: > > > > > At this point, I think it's correct to call GetACP even for > > > a Cygwin GDB. > > > > is *not* right. > > Can you explain it to me? This would only happen when we've > established that the application we're debugging is not linked to the > Cygwin DLL. Cygwin's nl_langinfo (CODESET) won't have any effect on a > non-Cygwin application. You're right. I re-read your original mail and it seems I misunderstood what you were trying to say. What I understood was that GetACP() is the correct default value for Cygwin GDB independent of the recognition of the target binary. Apparently you didn't mean that. Sorry for the confusion. Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat