Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for Cygwin and MingW builds

Corinna Vinschen
2010-03-01T20:06:25Z

On Mar 1 14:31, Daniel Jacobowitz wrote:
> On Mon, Mar 01, 2010 at 12:25:47PM -0700, Tom Tromey wrote:
> > Personally, I think that, given the existing nl_langinfo code (and
> > worse, Solaris hack) in _initialize_charset, it would be fine to add
> > some Cygwin change here. However, I won't approve a patch like that
> > over Daniel's objections.
>
> I don't mind hacks in general. I do mind hacks that are going to
> break my currently working builds.

That's fine, it's just that the current default breaks my builds.

> If you build an i686-mingw32
> to arm-linux debugger, and suddenly that defaults to UTF-16 instead of
> UCS-4, then I've got a problem.
>
> What do you suggest?

That's why I added the default now to _initialize_windows_nat. This
initialization function is only included into the build if you create
a GDB debugger for native Windows debugging. I don't see anything
wrong setting the default target charsets to UTF-16 and UTF-8/GetACP()
in this special case.

After all, it's still just a default setting. It doesn't seriously
break anything which can't be changed by a user setting.

Corinna

--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat