Re: [RFC-v2] Reenable compilation with cygwin 1.5 versions

Christopher Faylor
2010-03-04T16:38:44Z

On Thu, Mar 04, 2010 at 04:32:38PM +0100, Pierre Muller wrote:
>This new version of the patch that
>tries to separate what is directly use of UNICODE versions
>of Windows API from what is Cygwin API specific code.
>
> Following Christopher's suggestion,
>the patch for remote-fileio.c defines a static
>cygwin_conv_path function, with the minimum need to
>the restricted usage made inside that file.
> __USE_OLD_CYGWIN_API_ macro could be renamed something like
>__PROVIDE_LOCAL_CYGWIN_CONV_PATH_...
> This patch can now be considered as independent of the
>windows-nat.c patch.

When I said to define something I really meant use #define. I was
hoping that most of the #ifdef __CYGWIN__ and __USE_OLD_CYGWIN_API stuff
could be encapsulated at the top of the file. I've taken a rough stab
at implementing what I meant and it does seem feasible but I don't have
the time to do much right now (to say nothing of being not-extremely-interested
in maintaining old Cygwin or MinGW versions).

I'll send my proof-of-concept along sometime today.

cgf