From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18596 invoked by alias); 2 Mar 2010 18:22:47 -0000 Received: (qmail 18580 invoked by uid 22791); 2 Mar 2010 18:22:47 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Tue, 02 Mar 2010 18:22:40 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id DE5366D42F5; Tue, 2 Mar 2010 19:22:37 +0100 (CET) Date: Tue, 02 Mar 2010 18:22:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for Cygwin and MingW builds Message-ID: <20100302182237.GP5683@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <20100228150318.GA32463@calimero.vinschen.de> <20100228184749.GA17375@caradoc.them.org> <20100228192159.GP5683@calimero.vinschen.de> <20100228222702.GC29360@caradoc.them.org> <20100301103125.GB9730@calimero.vinschen.de> <20100301173054.GD5683@calimero.vinschen.de> <20100301193126.GA9416@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00066.txt.bz2 On Mar 2 10:58, Tom Tromey wrote: > >>>>> "Daniel" == Daniel Jacobowitz writes: > > >> Personally, I think that, given the existing nl_langinfo code (and > >> worse, Solaris hack) in _initialize_charset, it would be fine to add > >> some Cygwin change here. However, I won't approve a patch like that > >> over Daniel's objections. > > Daniel> I don't mind hacks in general. I do mind hacks that are going to > Daniel> break my currently working builds. If you build an i686-mingw32 > Daniel> to arm-linux debugger, and suddenly that defaults to UTF-16 instead of > Daniel> UCS-4, then I've got a problem. > > Yes, I see what you mean. Sorry for being so dense. > > Additionally, you're currently exposed to this scenario in the situation > where Corinna decides to fix the problem by implementing > nl_langinfo(CODESET) in Cygwin ;-) nl_langinfo(CODESET) exists in Cygwin. Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat