From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14034 invoked by alias); 2 Mar 2010 15:06:11 -0000 Received: (qmail 13971 invoked by uid 22791); 2 Mar 2010 15:06:10 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Mar 2010 15:06:05 +0000 Received: (qmail 20154 invoked from network); 2 Mar 2010 15:06:04 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 2 Mar 2010 15:06:04 -0000 Date: Tue, 02 Mar 2010 15:06:00 -0000 From: Daniel Jacobowitz To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Add missing baseaddr in dwarf2read.c Message-ID: <20100302150601.GC20342@caradoc.them.org> Mail-Followup-To: Doug Evans , gdb-patches@sourceware.org References: <20100302065440.4831784843@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100302065440.4831784843@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00050.txt.bz2 On Mon, Mar 01, 2010 at 10:54:40PM -0800, Doug Evans wrote: > Ok to check in? > > 2010-03-01 Doug Evans > > * dwarf2read.c (add_partial_subprogram): Add missing baseaddr to > lowpc,highpc args to addrmap_set_empty. Whoops. Pity we don't turn on the relevant compiler warning, baseaddr is never read. This is OK. -- Daniel Jacobowitz CodeSourcery