From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [RFA] Add missing baseaddr in dwarf2read.c
Date: Tue, 02 Mar 2010 06:54:00 -0000 [thread overview]
Message-ID: <20100302065440.4831784843@ruffy.mtv.corp.google.com> (raw)
Hi.
I was getting
"warning: (Internal error: pc 0x93a0 in read in psymtab, but not in symtab.)"
and traced it to an oversight in dwarf2read.c:add_partial_subprogram.
[target = android]
The real addresses were 0xafe0XXXX but the addresses in the addrmap were
off by baseaddr = 0xafe00000.
[tested on android and amd64-linux, no regressions]
Ok to check in?
2010-03-01 Doug Evans <dje@google.com>
* dwarf2read.c (add_partial_subprogram): Add missing baseaddr to
lowpc,highpc args to addrmap_set_empty.
Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.356
diff -u -p -r1.356 dwarf2read.c
--- dwarf2read.c 15 Feb 2010 20:48:57 -0000 1.356
+++ dwarf2read.c 2 Mar 2010 06:02:39 -0000
@@ -2695,7 +2695,8 @@ add_partial_subprogram (struct partial_d
baseaddr = ANOFFSET (objfile->section_offsets,
SECT_OFF_TEXT (objfile));
addrmap_set_empty (objfile->psymtabs_addrmap,
- pdi->lowpc, pdi->highpc - 1,
+ pdi->lowpc + baseaddr,
+ pdi->highpc - 1 + baseaddr,
cu->per_cu->psymtab);
}
if (!pdi->is_declaration)
next reply other threads:[~2010-03-02 6:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 6:54 Doug Evans [this message]
2010-03-02 15:06 ` Daniel Jacobowitz
2010-03-02 17:32 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302065440.4831784843@ruffy.mtv.corp.google.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox