From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5681 invoked by alias); 1 Mar 2010 20:06:25 -0000 Received: (qmail 5624 invoked by uid 22791); 1 Mar 2010 20:06:24 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Mon, 01 Mar 2010 20:06:19 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 67B686D42F5; Mon, 1 Mar 2010 21:06:16 +0100 (CET) Date: Mon, 01 Mar 2010 20:06:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for Cygwin and MingW builds Message-ID: <20100301200616.GG5683@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org, Tom Tromey References: <20100228142905.GB1556@caradoc.them.org> <20100228150318.GA32463@calimero.vinschen.de> <20100228184749.GA17375@caradoc.them.org> <20100228192159.GP5683@calimero.vinschen.de> <20100228222702.GC29360@caradoc.them.org> <20100301103125.GB9730@calimero.vinschen.de> <20100301173054.GD5683@calimero.vinschen.de> <20100301193126.GA9416@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100301193126.GA9416@caradoc.them.org> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00031.txt.bz2 On Mar 1 14:31, Daniel Jacobowitz wrote: > On Mon, Mar 01, 2010 at 12:25:47PM -0700, Tom Tromey wrote: > > Personally, I think that, given the existing nl_langinfo code (and > > worse, Solaris hack) in _initialize_charset, it would be fine to add > > some Cygwin change here. However, I won't approve a patch like that > > over Daniel's objections. > > I don't mind hacks in general. I do mind hacks that are going to > break my currently working builds. That's fine, it's just that the current default breaks my builds. > If you build an i686-mingw32 > to arm-linux debugger, and suddenly that defaults to UTF-16 instead of > UCS-4, then I've got a problem. > > What do you suggest? That's why I added the default now to _initialize_windows_nat. This initialization function is only included into the build if you create a GDB debugger for native Windows debugging. I don't see anything wrong setting the default target charsets to UTF-16 and UTF-8/GetACP() in this special case. After all, it's still just a default setting. It doesn't seriously break anything which can't be changed by a user setting. Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat