From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29137 invoked by alias); 1 Mar 2010 19:31:39 -0000 Received: (qmail 29124 invoked by uid 22791); 1 Mar 2010 19:31:39 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Mar 2010 19:31:35 +0000 Received: (qmail 3613 invoked from network); 1 Mar 2010 19:31:33 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Mar 2010 19:31:33 -0000 Date: Mon, 01 Mar 2010 19:31:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for Cygwin and MingW builds Message-ID: <20100301193126.GA9416@caradoc.them.org> Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: <20100228130500.GG5683@calimero.vinschen.de> <20100228142905.GB1556@caradoc.them.org> <20100228150318.GA32463@calimero.vinschen.de> <20100228184749.GA17375@caradoc.them.org> <20100228192159.GP5683@calimero.vinschen.de> <20100228222702.GC29360@caradoc.them.org> <20100301103125.GB9730@calimero.vinschen.de> <20100301173054.GD5683@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00029.txt.bz2 On Mon, Mar 01, 2010 at 12:25:47PM -0700, Tom Tromey wrote: > Personally, I think that, given the existing nl_langinfo code (and > worse, Solaris hack) in _initialize_charset, it would be fine to add > some Cygwin change here. However, I won't approve a patch like that > over Daniel's objections. I don't mind hacks in general. I do mind hacks that are going to break my currently working builds. If you build an i686-mingw32 to arm-linux debugger, and suddenly that defaults to UTF-16 instead of UCS-4, then I've got a problem. What do you suggest? -- Daniel Jacobowitz CodeSourcery