From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70580-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29755 invoked by alias); 1 Mar 2010 17:28:14 -0000
Received: (qmail 29741 invoked by uid 22791); 1 Mar 2010 17:28:13 -0000
X-Spam-Check-By: sourceware.org
Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234)     by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Mon, 01 Mar 2010 17:28:06 +0000
Received: by calimero.vinschen.de (Postfix, from userid 500) 	id 2344F6D42F5; Mon,  1 Mar 2010 18:28:04 +0100 (CET)
Date: Mon, 01 Mar 2010 17:28:00 -0000
From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for  Cygwin  and MingW builds
Message-ID: <20100301172804.GC5683@calimero.vinschen.de>
Reply-To: gdb-patches@sourceware.org
Mail-Followup-To: gdb-patches@sourceware.org
References: <20100228130500.GG5683@calimero.vinschen.de>  <20100228142905.GB1556@caradoc.them.org>  <20100228150318.GA32463@calimero.vinschen.de>  <20100228184749.GA17375@caradoc.them.org>  <20100228192159.GP5683@calimero.vinschen.de>  <20100228222702.GC29360@caradoc.them.org>  <20100301103125.GB9730@calimero.vinschen.de>  <83r5o43r2k.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83r5o43r2k.fsf@gnu.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00025.txt.bz2

On Mar  1 19:11, Eli Zaretskii wrote:
> > Date: Mon, 1 Mar 2010 11:31:25 +0100
> > From: Corinna Vinschen <vinschen@redhat.com>
> > 
> > @@ -2296,12 +2297,20 @@ void
> >  _initialize_windows_nat (void)
> >  {
> >    struct cmd_list_element *c;
> > +#ifndef __CYGWIN__
> > +  static char codepage[32];
> > +#endif
> >  
> >    init_windows_ops ();
> >  
> >  #ifdef __CYGWIN__
> >    cygwin_internal (CW_SET_DOS_FILE_WARNING, 0);
> > +  set_auto_target_charset ("UTF-8");
> > +#else
> > +  snprintf (codepage, 32, "CP%u", GetACP ());
>                          ^^
> Could this be `sizeof(codepage)' instead, please?

Yes, no problem.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat