Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for Cygwin and MingW builds

Corinna Vinschen
2010-03-01T17:31:01Z

On Mar 1 10:21, Tom Tromey wrote:
> >>>>> "Corinna" == Corinna Vinschen <vinschen@redhat.com> writes:
>
> Corinna> +void
> Corinna> +set_auto_target_wide_charset (char *charset)
>
> Argument should be const.
>
> Corinna> +void
> Corinna> +set_auto_target_charset (char *charset)
>
> Likewise.
>
> I think the documentation for these functions (in charset.h) should
> mention the expected lifetime of the arguments.

I don't understand. What do you mean by "expected lifetime"?!?

> Corinna> @@ -874,7 +917,7 @@ _initialize_charset (void)
> [...]
> Corinna> + auto_target_charset_name = auto_host_charset_name;
>
> Corinna> _initialize_windows_nat (void)
> [...]
> Corinna> + set_auto_target_charset ("UTF-8");
>
> This seems to introduce an ordering dependency between _initialize
> functions. My understanding is that we don't allow this.

It's just a default. The default of UTF-32 breaks wide char support for
UTF-16 targets. A native Cygwin or MingW GDB should have a sane default
for the target charsets. That's all I'm trying to accomplish.

Corinna

--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat