From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17301 invoked by alias); 1 Mar 2010 09:10:00 -0000 Received: (qmail 17275 invoked by uid 22791); 1 Mar 2010 09:09:57 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Mon, 01 Mar 2010 09:09:52 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id E87756D42F5; Mon, 1 Mar 2010 10:09:49 +0100 (CET) Date: Mon, 01 Mar 2010 09:10:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [RFA] windows-nat.c: Cygwin: Port to Cygwin 1.7 Message-ID: <20100301090949.GA9730@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <20100228150844.GH5683@calimero.vinschen.de> <20100228223046.GD29104@ednor.casa.cgf.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100228223046.GD29104@ednor.casa.cgf.cx> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00007.txt.bz2 On Feb 28 17:30, Christopher Faylor wrote: > On Sun, Feb 28, 2010 at 04:08:44PM +0100, Corinna Vinschen wrote: > >Hi, > > > >the below patch ports GDB to the latest Cygwin version 1.7. > > > >Three problems have to be fixed: > > > >- The maximum path length in Cygwin is no longer MAX_PATH. Rather it > > is PATH_MAX, which is now 4096. Actually, even paths up to 32K are > > supported, which is the maximum path length of the underlying Windows, > > but usually 4K is more than enough. > > > >- The aforementioned change required to provide a new Win32<->POSIX > > path conversion API which allows to handle paths longer than MAX_PATH. > > The old cygwin_conv_to_[full_]win32_path and cygwin_conf_to_[full_]posix > > path functions are deprecated now. The below patch uses the new > > cygwin_conv_path API instead. > > > >- The Windows ANSI functions have two drawbacks. > > > > - They return paths always in the default ANSI codepage, which is > > typically not the default codeset used in Cygwin 1.7 anymore. UTF-8 > > is now the default codeset in Cygwin. > > > > - They are restricted to a path length of MAX_PATH bytes. > > > > Since UTF-8 support and support for long paths are key changes in > > Cygwin 1.7, Cygwin now uses only Unicode Windows or native NT > > functions internally. To overcome the restrictions of the Win32 ANSI > > functions in GDB as well, the patch changes the affected calls to use > > the Unicode variation instead, too. > > > >The code for other Win32 targets is unaffected by this patch, except > >for a patch in get_image_name. The WideCharToMultiByte function is > >called with an incorrect target buffer size. > > > >Ok to apply? > > They look reasonable. I've had less comprehensive changes sitting in my > sandbox for a while. Please apply. Thanks, applied. Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat