From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1040 invoked by alias); 28 Feb 2010 19:22:09 -0000 Received: (qmail 1021 invoked by uid 22791); 28 Feb 2010 19:22:07 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Sun, 28 Feb 2010 19:22:02 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 788636D42F5; Sun, 28 Feb 2010 20:21:59 +0100 (CET) Date: Sun, 28 Feb 2010 19:22:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for Cygwin and MingW builds Message-ID: <20100228192159.GP5683@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <20100228130500.GG5683@calimero.vinschen.de> <20100228142905.GB1556@caradoc.them.org> <20100228150318.GA32463@calimero.vinschen.de> <20100228184749.GA17375@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100228184749.GA17375@caradoc.them.org> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00699.txt.bz2 On Feb 28 13:47, Daniel Jacobowitz wrote: > On Sun, Feb 28, 2010 at 04:03:18PM +0100, Corinna Vinschen wrote: > > If the codeset is target-specific anyway, then the idea of the > > GDB_DEFAULT_TARGET_WIDE_CHARSET and GDB_DEFAULT_TARGET_CHARSET variables > > is either wrong, or it must be possible to define them somewhere > > on a per-target base. What about windows-tdep.h? > > If it has to be per-target at all, it needs to go in gdbarch; it can't > be a #define any more, because we support multiple compiled-in > architectures. This is going to be significantly more complicated, > though; there needs to be an "auto (currently cp1252)" style setting. There is already a setting for the target charsets. We're just talking about setting a sane default. Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat