From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18078 invoked by alias); 28 Feb 2010 18:38:17 -0000 Received: (qmail 18058 invoked by uid 22791); 28 Feb 2010 18:38:15 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 28 Feb 2010 18:38:10 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1SIc9Rl020596 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 28 Feb 2010 13:38:09 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1SIc6T2011428 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 28 Feb 2010 13:38:08 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o1SIc521023673; Sun, 28 Feb 2010 19:38:05 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o1SIc5hf023672; Sun, 28 Feb 2010 19:38:05 +0100 Date: Sun, 28 Feb 2010 18:38:00 -0000 From: Jan Kratochvil To: Hui Zhu Cc: gdb-patches ml Subject: Re: [RFA] patch for [Bug gdb/11253] Message-ID: <20100228183805.GA23351@host0.dyn.jankratochvil.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00693.txt.bz2 On Fri, 26 Feb 2010 04:25:58 +0100, Hui Zhu wrote: > This patch is for bug 11253 http://sourceware.org/bugzilla/show_bug.cgi?id=11253 just extended it a bit but it remains the same. No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu. since Re: [RFA] Fix hw watchpoints in process record. From: Pedro Alves http://sourceware.org/ml/gdb-patches/2009-11/msg00476.html http://sourceware.org/ml/gdb-cvs/2009-11/msg00187.html commit 1ab0b876af2e2410fa462e901623669f29d75c89 there are IMO missing the resets in record_open. Thanks, Jan 2010-02-28 Jan Kratochvil Hui Zhu * record.c (record_open_1): Check tmp_to_stopped_by_watchpoint and tmp_to_stopped_data_address. (record_open): Reset tmp_to_stopped_by_watchpoint and tmp_to_stopped_data_address. * target.c (init_dummy_target): Add to_stopped_by_watchpoint and to_stopped_data_address. --- a/gdb/record.c +++ b/gdb/record.c @@ -867,6 +867,10 @@ record_open_1 (char *name, int from_tty) error (_("Could not find 'to_insert_breakpoint' method on the target stack.")); if (!tmp_to_remove_breakpoint) error (_("Could not find 'to_remove_breakpoint' method on the target stack.")); + if (!tmp_to_stopped_by_watchpoint) + error (_("Could not find 'to_stopped_by_watchpoint' method on the target stack.")); + if (!tmp_to_stopped_data_address) + error (_("Could not find 'to_stopped_data_address' method on the target stack.")); push_target (&record_ops); } @@ -897,6 +901,8 @@ record_open (char *name, int from_tty) tmp_to_xfer_partial = NULL; tmp_to_insert_breakpoint = NULL; tmp_to_remove_breakpoint = NULL; + tmp_to_stopped_by_watchpoint = NULL; + tmp_to_stopped_data_address = NULL; /* Set the beneath function pointers. */ for (t = current_target.beneath; t != NULL; t = t->beneath) --- a/gdb/target.c +++ b/gdb/target.c @@ -2838,6 +2838,9 @@ init_dummy_target (void) dummy_target.to_has_stack = (int (*) (struct target_ops *)) return_zero; dummy_target.to_has_registers = (int (*) (struct target_ops *)) return_zero; dummy_target.to_has_execution = (int (*) (struct target_ops *)) return_zero; + dummy_target.to_stopped_by_watchpoint = return_zero; + dummy_target.to_stopped_data_address = + (int (*) (struct target_ops *, CORE_ADDR *)) return_zero; dummy_target.to_magic = OPS_MAGIC; }