From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12297 invoked by alias); 28 Feb 2010 17:05:33 -0000 Received: (qmail 12260 invoked by uid 22791); 28 Feb 2010 17:05:32 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Sun, 28 Feb 2010 17:05:26 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id EA40D6D42F5; Sun, 28 Feb 2010 18:05:23 +0100 (CET) Date: Sun, 28 Feb 2010 17:05:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for Cygwin and MingW builds Message-ID: <20100228170523.GI5683@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <20100228130500.GG5683@calimero.vinschen.de> <838wadcn94.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <838wadcn94.fsf@gnu.org> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00682.txt.bz2 On Feb 28 18:56, Eli Zaretskii wrote: > > Date: Sun, 28 Feb 2010 14:05:00 +0100 > > From: Corinna Vinschen > > > > +/* The default output charset for Cygwin is UTF-8. The default output > > + charset for Win32 is the default ANSI codepage of the system, which > > + depends on the localization of the underlying Windows system. However, > > + CP1252 is a good default replacement for ISO-8859-1 at least. */ > > +#if defined (__CYGWIN__) > > +#define GDB_DEFAULT_TARGET_CHARSET "UTF-8" > > +#elif defined (_WIN32) > > +#define GDB_DEFAULT_TARGET_CHARSET "CP1252" > > +#endif > > Why cp1252? why not detect the ANSI codepage at run time, and make > more non-Latin users happy? How? Is there somewhere a function which converts a Windows codepage number into a iconv compatible codeset string? Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat