Re: [patch][python] Add symbol, symbol table and frame block support to GDB API

Tom Tromey
2010-02-23T23:09:47Z

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

One last thing I noticed...

Phil> +/* Require a valid block. All access to block_object->block should be
Phil> + gated by this call. */
Phil> +#define BLPY_REQUIRE_VALID(block_obj, block) \
Phil> + do { \
Phil> + block = block_object_to_block (block_obj); \
Phil> + if (block == NULL) \
Phil> + { \
Phil> + PyErr_SetString (PyExc_RuntimeError, \
Phil> + "Block is invalid."); \
Phil> + return NULL; \
Phil> + } \
Phil> + } while (0)

The error message here is missing _().
The others all seem to be ok.

Tom