Re: [patch][python] Add symbol, symbol table and frame block support to GDB API

Eli Zaretskii
2010-02-05T18:06:53Z

> Date: Fri, 05 Feb 2010 10:52:59 +0000
> From: Phil Muldoon <pmuldoon@redhat.com>
> CC: gdb-patches@sourceware.org
>
> On 02/03/2010 08:55 PM, Phil Muldoon wrote:
> > On 02/02/2010 08:14 PM, Eli Zaretskii wrote:
> >
> > I've attached an updated patch. What do you think?
> >
>
>
> I thought I'd nip in with another quick patch in-between this review.
> I fixed a few nits. Apologies for this, but this patch should be
> considered the latest.

Same comments as before. And maybe one more (sorry I didn't catch
that before):

> +@defivar Block function
> +The name of the block represented as a @code{gdb.Symbol}. If the
> +block is not named, then this attribute returns @code{None}. This
^^^^^^^
"holds", not "returns".