Re: [patch][python] Add symbol, symbol table and frame block support to GDB API

Eli Zaretskii
2010-02-15T18:45:55Z

> Date: Mon, 15 Feb 2010 15:15:18 +0000
> From: Phil Muldoon <pmuldoon@redhat.com>
> CC: gdb-patches ml <gdb-patches@sourceware.org>
>
> Eli,
>
> I've made that last changes you requested, too.
>
> What do you think?

I like it. But I want more ;-)

> +@defmethod Frame block
> +Returns the frame's code block. @xref{Blocks In Python}.
> +@end defmethod
> +
> +@defmethod Frame function
> +Returns the symbol for the function corresponding to this frame.
> +@xref{Symbols In Python}.
> +@end defmethod
> +
> @defmethod Frame older
> Return the frame that called this frame.
> @end defmethod
> @@ -20778,10 +20790,308 @@ Return the frame that called this frame.
> Return the frame called by this frame.
> @end defmethod
>
> +@defmethod Frame find_sal
> +Return the frame's symtab and line object.
> +@xref{Symbol Tables In Python}.
> +@end defmethod

Sometimes "Returns", sometimes "Return". I think the latter is
better, and we also use it more. In any case, we should use one or
the other consistently.

> +Please see @ref{Frames In Python} for a more in-depth discussion on
> +frames. Furthermore, see @ref{Stack, ,Examining the Stack} for more
> +detailed technical information on @value{GDBN}'s book-keeping of the
> +stack.

Please add a comma after the right brace that closes the argument of
@ref (two counts above). Otherwise, makeinfo will bitch at you.

Thanks.