Re: [patch][python] Add symbol, symbol table and frame block support to GDB API

Eli Zaretskii
2010-02-16T04:12:20Z

> Date: Mon, 15 Feb 2010 23:39:18 +0000
> From: Phil Muldoon <pmuldoon@redhat.com>
> CC: tromey@redhat.com, gdb-patches@sourceware.org
>
> On 02/15/2010 06:43 PM, Eli Zaretskii wrote:
>
> >> What do you think?
> >
> > I like it. But I want more ;-)
> >
> >> +@defmethod Frame find_sal
> >> +Return the frame's symtab and line object.
> >> +@xref{Symbol Tables In Python}.
> >> +@end defmethod
> >
> > Sometimes "Returns", sometimes "Return". I think the latter is
> > better, and we also use it more. In any case, we should use one or
> > the other consistently.
>
>
> Ok fixed in the patch and in a few other places the patch touches.

Actually, I meant the other way around: to say "Return". That's
because you also say "Set", not "Sets", etc.

> I'm not sure if your previous Ok carries forward here.

It is OK to commit once the above single issue is resolved.

Thanks.