Re: PATCH: Enable x86 XML target descriptions

Daniel Jacobowitz
2010-02-17T15:46:05Z

On Wed, Feb 17, 2010 at 07:41:48AM -0800, H.J. Lu wrote:
> > Also, you should split i386_linux_register_name(),
> > i386_linix_register_type() i386_linux_init_orig_eax() into seperate
> > i386 and amd64 versions, and get rid of all the #ifdef BFD64's in the
> > *-tdep.c files. Â There has been a clear split between 32-bit and
> > 64-bit versions of the *-tdep.c code and this diff blurrs that.
>
> I am not sure it is easy to do, especially for register description.
> I have an impression that tdesc_use_registers should only be called
> once per arch. i386 and amd64 belong to the same bfd_arch_i386.

So? You can still call set_gdbarch_register_name.

> I can try to minimize BFD64. But I am afraid that I can't totally avoid it.
> Is that acceptable?

No, amd64 support really should be in its own file.

> > I can't comment on the gdbserver bits; that is Daniel's territory.
> >
>
> Daniel, can you comment on gdbserver changes?

Sorry, I will look at it as soon as I have time.

--
Daniel Jacobowitz
CodeSourcery