From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] bfd/: bfd_elf_bfd_from_remote_memory 32bit &= 0xffffffff
Date: Sat, 20 Feb 2010 00:43:00 -0000 [thread overview]
Message-ID: <20100220004258.GA15783@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <m3sk8zg0hp.fsf@fleche.redhat.com>
On Wed, 17 Feb 2010 19:50:42 +0100, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>
> Tom> It seems like you could just call the struct CORE_ADDR.
>
> Jan> I thought it would be good to have different type for _address_ vs. for
> Jan> _displacement_. With this difference some math operations are no longer
> Jan> valid and I have discovered for example:
>
> Ok, I see. But in that case wouldn't you still need (or want) to make
> CORE_ADDR non-scalar, to avoid hidden errors?
Yes but that would be even much larger patch than just converting CORE_ADDRs
in use as a displacement into the non-scalar.
It is true this "displacement-only-CORE_ADDRs" has missed some usages of
CORE_ADDR as a displacement. But it is enough to catch the variable/field
declaration over all the use points of it if it would be left as a scalar.
Thanks,
Jan
next prev parent reply other threads:[~2010-02-20 0:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 11:57 Jan Kratochvil
2010-02-11 12:13 ` Andreas Schwab
2010-02-11 12:43 ` Jan Kratochvil
[not found] ` <20100211124302.GA8435__38068.0548646071$1265892205$gmane$org@host0.dyn.jankratochvil.net>
2010-02-16 23:24 ` Tom Tromey
2010-02-17 11:34 ` Jan Kratochvil
2010-02-17 18:50 ` Tom Tromey
2010-02-20 0:43 ` Jan Kratochvil [this message]
2010-02-11 12:51 ` Mark Kettenis
2010-02-11 13:30 ` [cancelled] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100220004258.GA15783@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox