From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Re: RFA: valgrind and the test suite, take 2
Date: Fri, 19 Feb 2010 18:09:00 -0000 [thread overview]
Message-ID: <20100219180945.GG2779@adacore.com> (raw)
In-Reply-To: <201002191745.18600.pedro@codesourcery.com>
> > This patch adds support for valgrind to the test suite. Unlike my last
> > patch along these lines, this one adds value above just setting GDB.
>
> Couldn't this be done with a board file?
It seems to be that it would be much more convenient to just be able
to defined VALGRIND to activate this feature. board files are the only
way we have to provide setup-specific information (such as target name,
etc), but the stuff to get testing under valgrind should be the same
for everyone...
Similarly, I have always found unfortunate that gdb.reverse testing
is conditioned on a setting that gets set in a board file. As a result
of this, I have never run the gdb.reverse testcases even though I could
have done so on my laptop.
--
Joel
next prev parent reply other threads:[~2010-02-19 18:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 17:24 Tom Tromey
2010-02-19 17:45 ` Pedro Alves
2010-02-19 18:09 ` Joel Brobecker [this message]
2010-02-19 19:34 ` Pedro Alves
2010-02-19 20:24 ` Joel Brobecker
2010-02-19 20:02 ` Tom Tromey
2010-02-19 20:28 ` Pedro Alves
2010-02-19 21:09 ` Tom Tromey
2010-02-19 21:27 ` Pedro Alves
2010-02-19 18:42 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219180945.GG2779@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox