From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8816 invoked by alias); 19 Feb 2010 15:19:31 -0000 Received: (qmail 8806 invoked by uid 22791); 19 Feb 2010 15:19:31 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Feb 2010 15:19:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 27F952BAC1E; Fri, 19 Feb 2010 10:19:26 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id eF1D6VCjSykl; Fri, 19 Feb 2010 10:19:26 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 108582BABF2; Fri, 19 Feb 2010 10:19:26 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A9B5AF5896; Fri, 19 Feb 2010 16:19:25 +0100 (CET) Date: Fri, 19 Feb 2010 15:19:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA/dwarf] Anonymous nested function causes SEGV during psymbol read Message-ID: <20100219151925.GE2779@adacore.com> References: <1266519724-4175-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00488.txt.bz2 > Joel> + /* Ignore subprograms that do not have a name. Such entries > Joel> + are incorrect, according to the DWARF standard, and we need > Joel> + a function name to create the associated partial symbol. */ > Joel> + if (!pdi->is_declaration && pdi->name) > Joel> add_partial_symbol (pdi, cu); > > I think it is worthwhile to call complaint for invalid DWARF. Not a problem - I will take care of that (I think we should complain in all cases, so that'll be two sites that need to be complaning). I'm answering now without a new patch because I won't have time to look into thin until early march, but I will. -- Joel