From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5092 invoked by alias); 19 Feb 2010 15:13:30 -0000 Received: (qmail 5072 invoked by uid 22791); 19 Feb 2010 15:13:28 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Feb 2010 15:13:22 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1JFDKU2027234 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 19 Feb 2010 10:13:20 -0500 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1JFDFEL026254 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 19 Feb 2010 10:13:18 -0500 Date: Fri, 19 Feb 2010 15:13:00 -0000 From: Phil Muldoon To: Eli Zaretskii Cc: tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [patch][python] Add symbol, symbol table and frame block support to GDB API Message-ID: <20100219151315.GA2681@localhost.localdomain> References: <4B66DA35.7080701@redhat.com> <4B796506.7010909@redhat.com> <20100219141457.GB2602@localhost.localdomain> <831vghxpwj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <831vghxpwj.fsf@gnu.org> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00487.txt.bz2 On Fri, Feb 19, 2010 at 04:26:36PM +0200, Eli Zaretskii wrote: > > Date: Fri, 19 Feb 2010 14:14:57 +0000 > > From: Phil Muldoon > > Cc: Eli Zaretskii , gdb-patches ml > > > > +* Python scripting > > + > > +The GDB Python API now has access to symbols, symbol tables, and > > +frame's code blocks. > > + > > This is okay, thanks. > > Please use "Return" rather than "Returns". > > > +Please see @ref{Frames In Python} for a more in-depth discussion on > > +frames. Furthermore, see @ref{Stack, ,Examining the Stack} for more > > +detailed technical information on @value{GDBN}'s book-keeping of the > > +stack. > > And still no comma after @ref{...}. Apologies for this. I keep the doc and code trees separate, and a slightly older documentation cut was in the code review. Locally I have these changes. Thanks for spotting it, though! Cheers, Phil