From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25047 invoked by alias); 18 Feb 2010 19:23:42 -0000 Received: (qmail 25034 invoked by uid 22791); 18 Feb 2010 19:23:41 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Feb 2010 19:23:37 +0000 Received: (qmail 24223 invoked from network); 18 Feb 2010 19:23:36 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 18 Feb 2010 19:23:36 -0000 From: Pedro Alves To: bug-gdb@gnu.org, gdb-patches@sourceware.org Subject: Re: some compile errors fo gdb-7.0.1 Date: Thu, 18 Feb 2010 19:23:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; x86_64; ; ) Cc: Harald Koenig , Harald Koenig References: <20100215141621.GA9469@atuin.science-computing.de> In-Reply-To: <20100215141621.GA9469@atuin.science-computing.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201002181923.34196.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00462.txt.bz2 [moving from bug-gdb@gnu.org, patches go to gdb-patches@] On Monday 15 February 2010 14:16:21, Harald Koenig wrote: > Hi, > > trying to compile gdb-7.0.1 on HP-UX, the hp cc complains about some problems in > mi-main.c and breakpoint.c symfile.c > > cc: "/soft/os/gdb/gdb-7.0.1/gdb-7.0.1/gdb/mi/mi-main.c", line 176: error 1610: Attempting to return value from function of type void. > cc: "/soft/os/gdb/gdb-7.0.1/gdb-7.0.1/gdb/breakpoint.c", line 8275: error 1000: Unexpected symbol: "}". > cc: "/soft/os/gdb/gdb-7.0.1/gdb-7.0.1/gdb/symfile.c", line 4036: error 1649: Illegal integer-pointer combination for >. > > obvious patches attached... Thanks. I've applied it to mainline, as below, after running the testsuite with it and finding on regressions. The breakpoint.c hunk was no longer necessary, the same fix had already been applied since 7 was released. I encourage you to try building cvs head, or a recent snapshot with hp cc so catch other possible tweaks necessary, as gdb 7.1 is close to branching out. -- Pedro Alves 2010-02-18 Harald Koenig * mi/mi-main.c (mi_cmd_exec_jump): Drop unneeded `return'. * symfile.c (symfile_map_offsets_to_segments): Fix assertion. --- gdb/mi/mi-main.c | 2 +- gdb/symfile.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Index: src/gdb/mi/mi-main.c =================================================================== --- src.orig/gdb/mi/mi-main.c 2010-02-17 19:41:35.000000000 +0000 +++ src/gdb/mi/mi-main.c 2010-02-18 18:13:08.000000000 +0000 @@ -190,7 +190,7 @@ void mi_cmd_exec_jump (char *args, char **argv, int argc) { /* FIXME: Should call a libgdb function, not a cli wrapper. */ - return mi_execute_async_cli_command ("jump", argv, argc); + mi_execute_async_cli_command ("jump", argv, argc); } static int Index: src/gdb/symfile.c =================================================================== --- src.orig/gdb/symfile.c 2010-02-17 22:01:03.000000000 +0000 +++ src/gdb/symfile.c 2010-02-18 18:13:08.000000000 +0000 @@ -3715,7 +3715,7 @@ symfile_map_offsets_to_segments (bfd *ab /* It doesn't make sense to call this function unless you have some segment base addresses. */ - gdb_assert (segment_bases > 0); + gdb_assert (num_segment_bases > 0); /* If we do not have segment mappings for the object file, we can not relocate it by segments. */