From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5007 invoked by alias); 17 Feb 2010 18:12:42 -0000 Received: (qmail 4998 invoked by uid 22791); 17 Feb 2010 18:12:41 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Feb 2010 18:12:38 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1HICSTN017219 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 17 Feb 2010 13:12:29 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1HICQf0014533 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 17 Feb 2010 13:12:28 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o1HICQoP009026; Wed, 17 Feb 2010 19:12:26 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o1HICPAe009025; Wed, 17 Feb 2010 19:12:25 +0100 Date: Wed, 17 Feb 2010 18:12:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, Daniel Jacobowitz Subject: Re: [patch] STT_GNU_IFUNC support Message-ID: <20100217181225.GA8632@host0.dyn.jankratochvil.net> References: <20100214203512.GA838@host0.dyn.jankratochvil.net> <201002171452.36043.pedro@codesourcery.com> <20100217173338.GA32328@host0.dyn.jankratochvil.net> <201002171755.10132.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201002171755.10132.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00431.txt.bz2 On Wed, 17 Feb 2010 18:55:10 +0100, Pedro Alves wrote: > On Wednesday 17 February 2010 17:33:38, Jan Kratochvil wrote: > > > > What about making this GNU-IFUNC inferior call scheduling follow the "step" > > > > policy? Maybe the whole inferior calls should follow the "step" policy? > > > > > > Or "on", should be the same. > > > > Not so. I find "step" to be the reasonable default (and it has been so for > > a long time before me in RHEL/Fedora) and I find GNU-IFUNC resolving with > > locked scheduler also as a reasonable default. I do not find > > "scheduler-locking on" as a reasonable GDB default. > > Oh, of course not. I was answering the first question, > about the specific infcall to resolve "strcmp" when the > user did "p strcmp" or "b strcmp". I assume you meant to > sched-lock that call, which would be the same as "on", > but maybe I misunderstood what you meant. We agree on the significant part. The other part is offtopic for IFUNC. Thanks, Jan ------------------------------------------------------------------------------ > A reply to > the second question would be similar to > the "That's another story." reply. ;-) The "That's another story." part: To make it whole more clear I would suggesting creating: set scheduler-locking-continue (on|off) set scheduler-locking-step (on|off) mapping current settings -> the new scheme as: set scheduler-locking on -> s-l-continue=on s-l-step=on set scheduler-locking step -> s-l-continue=off s-l-step=on set scheduler-locking off -> s-l-continue=off s-l-step=off and introducing for infcall/gnu-ifunc new settings: set scheduler-locking-infcall (on|off) set scheduler-locking-gnu-ifunc (on|off) Currently s-l-infcall behaves the same as s-l-continue. IMO s-l-infcall should behave more the same as s-l-step.