From: Daniel Jacobowitz <dan@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: PATCH: Enable x86 XML target descriptions
Date: Wed, 17 Feb 2010 15:46:00 -0000 [thread overview]
Message-ID: <20100217154553.GL9493@caradoc.them.org> (raw)
In-Reply-To: <6dc9ffc81002170741h3611c369mb3efd2b5bcdb8a34@mail.gmail.com>
On Wed, Feb 17, 2010 at 07:41:48AM -0800, H.J. Lu wrote:
> > Also, you should split i386_linux_register_name(),
> > i386_linix_register_type() i386_linux_init_orig_eax() into seperate
> > i386 and amd64 versions, and get rid of all the #ifdef BFD64's in the
> > *-tdep.c files. Â There has been a clear split between 32-bit and
> > 64-bit versions of the *-tdep.c code and this diff blurrs that.
>
> I am not sure it is easy to do, especially for register description.
> I have an impression that tdesc_use_registers should only be called
> once per arch. i386 and amd64 belong to the same bfd_arch_i386.
So? You can still call set_gdbarch_register_name.
> I can try to minimize BFD64. But I am afraid that I can't totally avoid it.
> Is that acceptable?
No, amd64 support really should be in its own file.
> > I can't comment on the gdbserver bits; that is Daniel's territory.
> >
>
> Daniel, can you comment on gdbserver changes?
Sorry, I will look at it as soon as I have time.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2010-02-17 15:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 20:03 H.J. Lu
2010-02-17 14:59 ` H.J. Lu
2010-02-17 15:23 ` Mark Kettenis
2010-02-17 15:42 ` H.J. Lu
2010-02-17 15:46 ` Daniel Jacobowitz [this message]
2010-02-17 16:19 ` Mark Kettenis
2010-02-18 5:44 ` H.J. Lu
2010-02-18 15:37 ` H.J. Lu
2010-02-18 23:01 ` H.J. Lu
2010-02-22 13:42 ` Mark Kettenis
2010-02-22 14:17 ` H.J. Lu
2010-02-22 15:01 ` Mark Kettenis
2010-02-22 15:27 ` H.J. Lu
2010-02-22 15:30 ` Daniel Jacobowitz
2010-02-22 15:39 ` H.J. Lu
2010-02-28 20:30 ` Mark Kettenis
2010-02-28 20:58 ` H.J. Lu
2010-02-28 22:23 ` Daniel Jacobowitz
2010-02-22 14:41 ` Daniel Jacobowitz
2010-02-22 15:34 ` H.J. Lu
2010-02-22 15:52 ` Daniel Jacobowitz
2010-02-22 15:58 ` H.J. Lu
2010-02-22 16:10 ` Daniel Jacobowitz
2010-02-22 16:58 ` Mark Kettenis
2010-02-22 17:03 ` Daniel Jacobowitz
2010-02-22 19:52 ` Mark Kettenis
2010-02-22 21:06 ` H.J. Lu
2010-02-22 21:31 ` Mark Kettenis
2010-02-22 21:41 ` H.J. Lu
2010-02-22 22:05 ` H. Peter Anvin
2010-02-22 22:07 ` H.J. Lu
2010-02-22 22:15 ` H. Peter Anvin
2010-02-22 22:21 ` H.J. Lu
2010-02-28 20:12 ` Mark Kettenis
2010-02-22 21:04 ` H.J. Lu
2010-02-28 21:16 ` H.J. Lu
2010-03-01 14:49 ` Mark Kettenis
2010-03-01 17:07 ` Daniel Jacobowitz
2010-03-01 17:09 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217154553.GL9493@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox