From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 411 invoked by alias); 17 Feb 2010 14:59:29 -0000 Received: (qmail 400 invoked by uid 22791); 17 Feb 2010 14:59:27 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_00,NO_DNS_FOR_FROM X-Spam-Check-By: sourceware.org Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Feb 2010 14:59:22 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 17 Feb 2010 06:56:58 -0800 X-ExtLoop1: 1 Received: from gnu-6.sc.intel.com ([10.3.194.107]) by orsmga001.jf.intel.com with ESMTP; 17 Feb 2010 06:58:07 -0800 Received: by gnu-6.sc.intel.com (Postfix, from userid 500) id 8040B812344; Wed, 17 Feb 2010 06:58:20 -0800 (PST) Date: Wed, 17 Feb 2010 14:59:00 -0000 From: "H.J. Lu" To: "H.J. Lu" Cc: GDB Subject: Re: PATCH: Enable x86 XML target descriptions Message-ID: <20100217145820.GA20676@lucon.org> Reply-To: "H.J. Lu" References: <20100210200303.GA19632@lucon.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100210200303.GA19632@lucon.org> User-Agent: Mutt/1.5.20 (2009-08-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00421.txt.bz2 On Wed, Feb 10, 2010 at 12:03:03PM -0800, H.J. Lu wrote: > Hi, > > This patch enables x86 XML target descriptions. I used > i386_linux_init_orig_eax to support the old gdbserver which doesn't > have XML target descriptions. > > The register description processing is handled in i386_gdbarch_init > for 32bit/64bit as well as all ABIs to avoid code duplication and > unnecessary complexity. > > OK to install? > > BTW, I have a followup patch to support al, ax and eax pseudo registers. > > Thanks. > > > H.J. > ---- > gdb/ > > 2010-02-10 H.J. Lu > > * amd64-linux-nat.c (_initialize_amd64_linux_nat): Set > to_read_description to i386_linux_read_description. > * i386-linux-nat.c (_initialize_i386_linux_nat): Likewise. > > * amd64-linux-tdep.c (amd64_linux_register_name): Removed. > (amd64_linux_register_type): Likewise. > (amd64_linux_init_abi): Don't call set_gdbarch_num_regs, > set_gdbarch_register_name nor set_gdbarch_register_type. Call > i386_linux_init_orig_eax and set_gdbarch_core_read_description. > > * amd64-linux-tdep.h: Include "i386-linux-tdep.h". > > * amd64-tdep.c (amd64_register_names): Make it global. > (amd64_register_name): Removed. > (amd64_register_type): Likewise. > (amd64_init_abi): Don't call set_gdbarch_num_regs, > set_gdbarch_register_name nor set_gdbarch_register_type. > > * amd64-tdep.h (amd64_register_names): New. > > * i386-linux-tdep.c: Include "amd64-tdep.h" and > * "amd64-linux-tdep.h" instead "i386-tdep.h" and > "i386-linux-tdep.h". Include features/i386/i386-linux.c and > features/i386/amd64-linux.c. > (i386_linux_register_name): Support BFD64. > (i386_linux_register_type): New. > (i386_linux_init_orig_eax): Likewise. > (i386_linux_core_read_description): Likewise. > (i386_linux_read_description): Likewise. > (i386_linux_init_abi): Don't call set_gdbarch_num_regs nor > set_gdbarch_register_name. Call i386_linux_init_orig_eax and > set_gdbarch_core_read_description. > (_initialize_i386_linux_tdep): Call initialize_tdesc_i386_linux > and initialize_tdesc_x86_64_linux. > > * i386-linux-tdep.h (i386_linux_core_read_description): New. > (i386_linux_read_description): Likewise. > (i386_linux_init_orig_eax): Likewise. > > * i386-tdep.c: Include "amd64-tdep.h" instead of "i386-tdep.h". > Include features/i386/i386.c and features/i386/amd64.c. > (i386_register_names): Make it const. > (i386_mmx_names): Likewise. > (i386_num_register_names): Removed. > (i386_register_name): Likewise. > (i386_eflags_type): Likewise. > (i386_mxcsr_type): Likewise. > (i386_sse_type): Likewise. > (i386_register_type): Likewise. > (i387_ext_type): Call tdesc_find_type instead of arch_float_type. > (i386_pseudo_register_name): New. > (i386_pseudo_register_type): Likewise. > (i386_mmx_type): Make it static. > (i386_gdbarch_init): Support both 32bit and 64bit x86 target > descriptions. Don't call set_gdbarch_register_name nor > set_gdbarch_register_type. Call set_tdesc_pseudo_register_type, > set_tdesc_pseudo_register_name and tdesc_use_registers. > (_initialize_i386_tdep): Call initialize_tdesc_i386 and > initialize_tdesc_x86_64. > > * i386-tdep.h (gdbarch_tdep): Remove i386_eflags_type, > i386_mxcsr_type and i386_sse_type. > (i386_eflags_type): Removed. > (i386_mxcsr_type): Likewise. > (i386_mmx_type): Likewise. > (i386_sse_type): Likewise. > (i386_register_name): Likewise. > > * regformats/i386/i386-linux.dat: Generated. > * regformats/i386/i386.dat: Likewise. > * regformats/i386/amd64-linux.dat: Likewise. > * regformats/i386/amd64.dat: Likewise. > > * regformats/reg-i386-linux.dat: Removed. > * regformats/reg-i386.dat: Likewise. > * regformats/reg-x86-64-linux.dat: Likewise. > * regformats/reg-x86-64.dat: Likewise. > > gdb/gdbserver/ > > 2010-02-10 H.J. Lu > > * Makefile.in (clean): Replace reg-i386.c, reg-x86-64.c, > reg-i386-linux.c and reg-x86-64-linux.c with i386.c, amd64.c, > i386-linux.c and amd64-linux.c. > (reg-i386.o): Removed. > (reg-i386.c): Likewise. > (reg-i386-linux.o): Likewise. > (reg-i386-linux.c): Likewise. > (reg-x86-64.o): Likewise. > (reg-x86-64.c): Likewise. > (reg-x86-64-linux.o): Likewise. > (reg-x86-64-linux.c): Likewise. > (i386.o): New. > (i386.c): Likewise. > (i386-linux.o): Likewise. > (i386-linux.c): Likewise. > (amd64.o): Likewise. > (amd64.c): Likewise. > (amd64-linux.o): Likewise. > (amd64-linux.c): Likewise. > > * configure.srv (srv_i386_regobj): New. > (srv_i386_linux_regobj): Likewise. > (srv_amd64_regobj): Likewise. > (srv_amd64_linux_regobj): Likewise. > (srv_i386_32bit_xmlfiles): Likewise. > (srv_i386_64bit_xmlfiles): Likewise. > (srv_i386_xmlfiles): Likewise. > (srv_amd64_xmlfiles): Likewise. > (srv_i386_linux_xmlfiles): Likewise. > (srv_amd64_linux_xmlfiles): Likewise. > (i[34567]86-*-cygwin*): Set srv_regobj to $srv_i386_regobj. Set > srv_xmlfiles to $srv_i386_xmlfiles. > (i[34567]86-*-mingw32ce*): Likewise. > (i[34567]86-*-mingw*): Likewise. > (i[34567]86-*-nto*): Likewise. > (i[34567]86-*-linux*): Set srv_regobj to $srv_i386_linux_regobj > and $srv_amd64_linux_regobj. Set srv_xmlfiles to > $srv_i386_linux_xmlfiles and $srv_amd64_linux_xmlfiles. > (x86_64-*-linux*): Likewise. > > * linux-x86-low.c (init_registers_x86_64_linux): Removed. > (init_registers_amd64_linux): New. > (x86_arch_setup): Replace init_registers_x86_64_linux with > init_registers_amd64_linux. > Any objections to enable XML target descriptions for x86? Any comments? Thanks. H.J.