Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch] STT_GNU_IFUNC support
Date: Mon, 15 Feb 2010 18:49:00 -0000	[thread overview]
Message-ID: <20100215184932.GA18278@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20100215184048.GA16276@caradoc.them.org>

On Mon, 15 Feb 2010 19:40:50 +0100, Daniel Jacobowitz wrote:
> On Sun, Feb 14, 2010 at 09:35:12PM +0100, Jan Kratochvil wrote:
> > This implementation resolves ifunc in an uncached way by an inferior call any
> > time the symbol resolution is needed.  It does not try to pick out the jump
> > address value from ".got.plt" as filled there by ld.so.  (GDB stepping into
> > library functions also does not try to do so.)
> 
> Do you mean that "print strcmp" or "break strcmp" is now going to do
> an inferior call?

Yes.


> Inferior calls are very slow, and they can go wrong (pending signals,
> misbehaving programs, etc).  I believe we should make an effort to
> minimize them.

Caching may not help as during first "print strcmp" it may be called neither
by the inferior nor by gdb yet.  Making the "print strcmp" output dependent on
whether "strcmp" has been already called looks too non-deterministic to me.
Displaying the indirect function resolver on "print strcmp" looks to me as
needlessly complex for normal application developers.


> For user messages, maybe we should call these "indirect functions";
> that's what ifunc is short for.

OK.


Thanks,
Jan


  reply	other threads:[~2010-02-15 18:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-14 20:35 Jan Kratochvil
2010-02-14 21:43 ` Mark Kettenis
2010-02-14 21:59   ` Jan Kratochvil
2010-02-15 18:40 ` Daniel Jacobowitz
2010-02-15 18:49   ` Jan Kratochvil [this message]
2010-02-17 12:34   ` Pedro Alves
2010-02-17 14:19     ` Jan Kratochvil
2010-02-17 14:46       ` Daniel Jacobowitz
2010-02-17 17:45         ` Jan Kratochvil
2010-02-17 14:52       ` Pedro Alves
2010-02-17 17:33         ` Jan Kratochvil
2010-02-17 17:55           ` Pedro Alves
2010-02-17 18:12             ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100215184932.GA18278@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox