From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23313 invoked by alias); 13 Feb 2010 12:05:02 -0000 Received: (qmail 23296 invoked by uid 22791); 13 Feb 2010 12:05:01 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 13 Feb 2010 12:04:56 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1DC4skJ021514 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 13 Feb 2010 07:04:55 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1DC4qR5006311 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 13 Feb 2010 07:04:54 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o1DC4qg7002605; Sat, 13 Feb 2010 13:04:52 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o1DC4pHw002604; Sat, 13 Feb 2010 13:04:51 +0100 Date: Sat, 13 Feb 2010 12:05:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [patch] Sanity check PIE displacement (like the PIC one) Message-ID: <20100213120451.GA2293@host0.dyn.jankratochvil.net> References: <20100201012004.GA6015@host0.dyn.jankratochvil.net> <20100211200506.GA24110@caradoc.them.org> <20100211222113.GA31323@host0.dyn.jankratochvil.net> <20100211222604.GA1465@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100211222604.GA1465@caradoc.them.org> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00334.txt.bz2 On Thu, 11 Feb 2010 23:26:07 +0100, Daniel Jacobowitz wrote: > On Thu, Feb 11, 2010 at 11:21:13PM +0100, Jan Kratochvil wrote: > > The life-saver message is IMO "B" but the message(s) being discussed to be > > removed is A1+A2. > > > > Is the attached patch what everone agrees upon or have I not understood it? > > Fine with me. Or you could just use verbose. Checked it in pre-approved for "verbose" without changing the content to move forward with the PIE part. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2010-02/msg00100.html --- src/gdb/ChangeLog 2010/02/12 21:28:25 1.11356 +++ src/gdb/ChangeLog 2010/02/13 12:02:26 1.11357 @@ -1,3 +1,8 @@ +2010-02-13 Jan Kratochvil + + * solib-svr4.c: (LM_ADDR_CHECK): Print successful prelink adjustment + only if INFO_VERBOSE. + 2010-02-12 Tomas Holmberg * mi/mi-main.c: Added the --reverse flag to the following MI --- src/gdb/solib-svr4.c 2010/02/11 23:07:23 1.119 +++ src/gdb/solib-svr4.c 2010/02/13 12:02:28 1.120 @@ -234,10 +234,13 @@ { l_addr = l_dynaddr - dynaddr; - warning (_(".dynamic section for \"%s\" " - "is not at the expected address"), so->so_name); - warning (_("difference appears to be caused by prelink, " - "adjusting expectations")); + if (info_verbose) + { + warning (_(".dynamic section for \"%s\" " + "is not at the expected address"), so->so_name); + warning (_("difference appears to be caused by prelink, " + "adjusting expectations")); + } } else warning (_(".dynamic section for \"%s\" " --- src/gdb/testsuite/ChangeLog 2010/02/12 21:39:27 1.2129 +++ src/gdb/testsuite/ChangeLog 2010/02/13 12:02:29 1.2130 @@ -1,3 +1,7 @@ +2010-02-13 Jan Kratochvil + + * gdb.base/prelink.exp (set verbose on): New. + 2010-02-12 Tomas Holmberg * mi-reverse.exp: New file. Test for reverse option to the --- src/gdb/testsuite/gdb.base/prelink.exp 2010/01/01 07:32:01 1.10 +++ src/gdb/testsuite/gdb.base/prelink.exp 2010/02/13 12:02:29 1.11 @@ -109,6 +109,9 @@ gdb_reinitialize_dir $srcdir/$subdir gdb_load ${binfile} +# Print the "adjusting expectations" message. +gdb_test "set verbose on" + set test "prelink" global gdb_prompt gdb_test_multiple "core-file $objdir/$subdir/prelink.core" "$test" {