Re: [patch] Sanity check PIE displacement (like the PIC one)

[Daniel Jacobowitz <dan@codesourcery.com>]

On Thu, Feb 11, 2010 at 12:43:00PM -0700, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Thanks for pinging this patch.
> 
> Jan> The current PIC message being printed "all the time" is:
> Jan> warning: .dynamic section for "/lib64/librt-2.11.1.so" is not at the expected address
> Jan> warning: difference appears to be caused by prelink, adjusting expectations
> [...]
> Jan> I do not find the current PIC message too useful (moreover without
> Jan> any offset printed).  Therefore I am open to removing both the PIC
> Jan> (and new PIE) messages when the offset is successfuly considered as
> Jan> valid.
> 
> I don't find that PIC message particularly useful, either.
> Is there some situation where that information is helpful?
> If not, then IMO we should remove it.

Under what circumstances would you remove it?  I'd favor removing the
former warning when the second one would be printed, but not otherwise.

The first message is a real life-saver.  It triggers when you have the
wrong C library when loading a core file or using a sysroot.

-- 
Daniel Jacobowitz
CodeSourcery