From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1415 invoked by alias); 10 Feb 2010 18:38:11 -0000 Received: (qmail 1406 invoked by uid 22791); 10 Feb 2010 18:38:11 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Feb 2010 18:38:07 +0000 Received: (qmail 15423 invoked from network); 10 Feb 2010 18:38:05 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 Feb 2010 18:38:05 -0000 Date: Wed, 10 Feb 2010 18:38:00 -0000 From: Daniel Jacobowitz To: "H.J. Lu" Cc: GDB , Mark Kettenis Subject: Re: PATCH: Cache types from target description Message-ID: <20100210183800.GA25489@caradoc.them.org> Mail-Followup-To: "H.J. Lu" , GDB , Mark Kettenis References: <20100205011447.GA28263@lucon.org> <20100208185454.GA21449@lucon.org> <20100209154513.GA27404@lucon.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100209154513.GA27404@lucon.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00271.txt.bz2 On Tue, Feb 09, 2010 at 07:45:13AM -0800, H.J. Lu wrote: > 2010-02-09 H.J. Lu > > * target-descriptions.c (tdesc_type): Add TDESC_TYPE_I387_EXT, > TDESC_TYPE_I386_EFLAGS and TDESC_TYPE_I386_MXCSR. > (tdesc_predefined_types): Add i387_ext, i386_eflags and > i386_mxcsr. > (tdesc_find_type): New. > (tdesc_gdb_type): Use tdesc_find_type. Handle TDESC_TYPE_I387_EXT, > TDESC_TYPE_I386_EFLAGS and TDESC_TYPE_I386_MXCSR. > > * target-descriptions.h (tdesc_find_type): New. This is OK. I am not happy having the flag types in this file, but I don't see a better way yet. Really they should be described in the XML file! -- Daniel Jacobowitz CodeSourcery