From: Daniel Jacobowitz <dan@codesourcery.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: Updates support for breakpoints that generate SIGILL
Date: Mon, 08 Feb 2010 19:45:00 -0000 [thread overview]
Message-ID: <20100208194543.GH9493@caradoc.them.org> (raw)
In-Reply-To: <201002081935.o18JZIMA023833@d12av02.megacenter.de.ibm.com>
On Mon, Feb 08, 2010 at 08:35:17PM +0100, Ulrich Weigand wrote:
> Unfortunately this change broke Cell/B.E. debugging.
>
> The problem is that with the change, handle_inferior_event will now
> *always* look up a regcache, even when the process has exited.
>
> Before the patch, the code has always taken care to avoid that; while
> some targets don't mind, others will break (in particular, the Cell/B.E.
> multi-arch target does).
>
> The patch below changes this to only look up the regcache when needed
> (in particular, this implies the process is still there).
>
> Tested on Cell/B.E. (ppc32 and ppc64) with no regressions.
>
> Does this look OK to you?
Sorry for the breakage. Yes, your fix looks good to me.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2010-02-08 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 21:59 Daniel Jacobowitz
2010-01-29 4:10 ` Joel Brobecker
2010-01-29 15:40 ` Daniel Jacobowitz
2010-02-08 19:35 ` Ulrich Weigand
2010-02-08 19:45 ` Daniel Jacobowitz [this message]
2010-02-08 19:51 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100208194543.GH9493@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox