From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 452 invoked by alias); 8 Feb 2010 14:14:37 -0000 Received: (qmail 434 invoked by uid 22791); 8 Feb 2010 14:14:35 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Feb 2010 14:14:30 +0000 Received: (qmail 11230 invoked from network); 8 Feb 2010 14:14:28 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Feb 2010 14:14:28 -0000 Date: Mon, 08 Feb 2010 14:14:00 -0000 From: Daniel Jacobowitz To: "H.J. Lu" Cc: Mark Kettenis , gdb-patches@sourceware.org Subject: Re: PATCH: PATCH: Add builtin floating point types Message-ID: <20100208141423.GA26959@caradoc.them.org> Mail-Followup-To: "H.J. Lu" , Mark Kettenis , gdb-patches@sourceware.org References: <20100205011447.GA28263@lucon.org> <201002072152.o17LqEm7030005@glazunov.sibelius.xs4all.nl> <6dc9ffc81002071400u5bad1726v93330aeb38246143@mail.gmail.com> <20100207221444.GA5399@caradoc.them.org> <6dc9ffc81002071425y74b5bb8eha47bacc6f1d2a33e@mail.gmail.com> <6dc9ffc81002071503r79077130meb9f66a6cf51ed09@mail.gmail.com> <20100207230748.GA8766@caradoc.them.org> <6dc9ffc81002071816n44363fffpe08a964e513a10c8@mail.gmail.com> <20100208041656.GA26375@caradoc.them.org> <6dc9ffc81002072116sd0797ecnf24550199f1d12a2@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6dc9ffc81002072116sd0797ecnf24550199f1d12a2@mail.gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00206.txt.bz2 On Sun, Feb 07, 2010 at 09:16:25PM -0800, H.J. Lu wrote: > in gdbtypes.c. struct arch_type will have > > struct type *arch_ieee_single; > struct type *arch_ieee_double; > struct type *arch_i387_ext; > > They will be lazy initialized. I thought that was what you suggested. This hasn't changed anything; it still has to know about i387_ext. There are at least two options. We could use a per-gdbarch hash table to cache the result of arch_float_type (in arch_float_type, not in its caller). Or we could put the cache in tdesc_gdb_type, which is probably easier. There's already an ARM-specific type there. It's there because the XML format already has to know the magic arch-specific names and document them in the GDB manual appendix. -- Daniel Jacobowitz CodeSourcery