From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70035-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2336 invoked by alias); 7 Feb 2010 22:43:42 -0000
Received: (qmail 2322 invoked by uid 22791); 7 Feb 2010 22:43:41 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 07 Feb 2010 22:43:37 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o17MhTlL028774; 	Sun, 7 Feb 2010 23:43:29 +0100 (CET)
Received: (from kettenis@localhost) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o17MhS8p010756; 	Sun, 7 Feb 2010 23:43:28 +0100 (CET)
Date: Sun, 07 Feb 2010 22:43:00 -0000
Message-Id: <201002072243.o17MhS8p010756@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: hjl.tools@gmail.com
CC: gdb-patches@sourceware.org
In-reply-to: <6dc9ffc81002071350t74e2b3abm39b798ce26192254@mail.gmail.com> 	(hjl.tools@gmail.com)
Subject: Re: PATCH: Add x86 xml files
References: <20100204235952.GA27284@lucon.org> 	 <20100205000052.GA27361@lucon.org> 	 <201002072129.o17LTOia028451@glazunov.sibelius.xs4all.nl> <6dc9ffc81002071350t74e2b3abm39b798ce26192254@mail.gmail.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00194.txt.bz2

> Date: Sun, 7 Feb 2010 13:50:32 -0800
> From: "H.J. Lu" <hjl.tools@gmail.com>
>
> >> +I386-XMLTOC = $(addsuffix .xml, $(filter i386/%, $(WHICH)))
> >> +I386-CFILES = $(patsubst %.xml,%.c,$(I386-XMLTOC))
> >
> > Why are you introducing these variables?
> 
> They are used by the new "i386-cfiles" target.
> 
> >>  all: $(OUTPUTS)
> >>
> >>  $(outdir)/%.dat: %.xml number-regs.xsl sort-regs.xsl gdbserver-regs.xsl
> >> @@ -71,6 +80,8 @@ $(outdir)/%.dat: %.xml number-regs.xsl sort-regs.xsl gdbserver-regs.xsl
> >>       sh ../../move-if-change $(outdir)/$*.tmp $(outdir)/$*.dat
> >>
> >>  cfiles: $(CFILES)
> >> +i386-cfiles: $(I386-CFILES)
> >
> > And this target?
> 
> You need a working gdb for your target with XML support to generate
> those C files for gdbserver. That is why XMLTOC is empty and GDB
> is false. To generate those C files, you have to do
> 
> # make cfiles GDB="your new GDB" XMLTOC="your XML files"
> 
> I added this target so that I can do
> 
> # make i386-cfiles GDB="my new GDB"
> 
> to generate i386 C files for gdbserver without specifying XMLTOC at
> command line. It is very convenience for maintenance.

Well, given that none of the other architectures have such a target, I
think you shouldn't add this only for i386.

If you really think the convenience is important, it has to be added
for the other architectures as well.  But that's better done in a
seperarate patch.