From: Daniel Jacobowitz <dan@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: Add x86 xml files
Date: Sun, 07 Feb 2010 21:50:00 -0000 [thread overview]
Message-ID: <20100207214956.GA3528@caradoc.them.org> (raw)
In-Reply-To: <20100205000052.GA27361@lucon.org>
On Thu, Feb 04, 2010 at 04:00:52PM -0800, H.J. Lu wrote:
> +<!DOCTYPE feature SYSTEM "gdb-target.dtd">
> +<feature name="org.gnu.gdb.i386.core">
In addition to Mark's comments:
* The new features will need to be documented in the manual. I'd
recommend doing that along with the XML files.
* I can't remember exactly why there are some previously existing
features with the same name and two possible contents. It seems like
a better idea to call one of these org.gnu.gdb.x86_64.* (or x86-64 or
amd64 or whatever).
Otherwise, it seems fine to me.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2010-02-07 21:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 0:01 H.J. Lu
2010-02-05 0:01 ` H.J. Lu
2010-02-07 21:29 ` Mark Kettenis
2010-02-07 21:50 ` H.J. Lu
2010-02-07 22:43 ` Mark Kettenis
2010-02-07 21:50 ` Daniel Jacobowitz [this message]
2010-02-07 21:55 ` H.J. Lu
2010-02-07 22:23 ` Daniel Jacobowitz
2010-02-07 22:36 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100207214956.GA3528@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox