From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12023 invoked by alias); 7 Feb 2010 21:15:28 -0000 Received: (qmail 12007 invoked by uid 22791); 7 Feb 2010 21:15:27 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 07 Feb 2010 21:15:23 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o17LFHB1029221; Sun, 7 Feb 2010 22:15:17 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o17LFFnT030072; Sun, 7 Feb 2010 22:15:15 +0100 (CET) Date: Sun, 07 Feb 2010 21:15:00 -0000 Message-Id: <201002072115.o17LFFnT030072@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: hjl.tools@gmail.com CC: gdb-patches@sourceware.org In-reply-to: <20100207174213.GA10424@lucon.org> (hongjiu.lu@intel.com) Subject: Re: PATCH: Check section size for valid core sections References: <20100207174213.GA10424@lucon.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00182.txt.bz2 > Date: Sun, 7 Feb 2010 09:42:13 -0800 > From: "H.J. Lu" > > I added a new core section, .reg-xstate, to support x86 XSAVE extended > state. We can read it on any machine. But we can only write it on > machines with x86 XSAVE extended state. I have > > /* Supported register note sections. */ > static struct core_regset_section amd64_linux_regset_sections[] = > { > { ".reg", 144, "general-purpose" }, > { ".reg2", 512, "floating-point" }, > { ".reg-xstate", 0, "XSAVE extended state" }, > { NULL, 0 } > }; > > I update its size with > > /* Update the XSAVE extended state size on Linux/x86 host. Need it > for "gcore". */ > i386_xstate_init (); > amd64_linux_regset_sections[2].size = i386_xstate.size; > > If the machine suppors XSAVE, size will be non-zero. We can still > read the core section since size is only used for gcore. OK to install? Sorry, but this makes no sense to me. > 2010-02-07 H.J. Lu > > * linux-nat.c (linux_nat_do_thread_registers): Check section > size instead of section name for valid core sections. > > diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c > index 7fc9584..44a3288 100644 > --- a/gdb/linux-nat.c > +++ b/gdb/linux-nat.c > @@ -4112,9 +4112,12 @@ linux_nat_do_thread_registers (bfd *obfd, ptid_t ptid, > /* The loop below uses the new struct core_regset_section, which stores > the supported section names and sizes for the core file. Note that > note PRSTATUS needs to be treated specially. But the other notes are > - structurally the same, so they can benefit from the new struct. */ > + structurally the same, so they can benefit from the new struct. We > + check section size instead of section name for valid core sections > + since we can read x86 XSAVE extended state core section, but we can > + write it only if x86 XSAVE extended state is available natively. */ > if (core_regset_p && sect_list != NULL) > - while (sect_list->sect_name != NULL) > + while (sect_list->size != 0) > { > /* .reg was already handled above. */ > if (strcmp (sect_list->sect_name, ".reg") == 0) >