From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20398 invoked by alias); 4 Feb 2010 00:25:27 -0000 Received: (qmail 20385 invoked by uid 22791); 4 Feb 2010 00:25:26 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Feb 2010 00:25:21 +0000 Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id o140PIdt016301 for ; Thu, 4 Feb 2010 00:25:19 GMT Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.18.118.116]) by wpaz21.hot.corp.google.com with ESMTP id o140PHCt028749 for ; Wed, 3 Feb 2010 16:25:17 -0800 Received: by ruffy.mtv.corp.google.com (Postfix, from userid 67641) id DF79F84414; Wed, 3 Feb 2010 16:25:16 -0800 (PST) To: gdb-patches@sourceware.org Subject: [patch] gdb.exp (INTERNAL_GDBFLAGS): Don't override value provided by user. Message-Id: <20100204002516.DF79F84414@ruffy.mtv.corp.google.com> Date: Thu, 04 Feb 2010 00:25:00 -0000 From: dje@google.com (Doug Evans) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00097.txt.bz2 Hi. I will check this in tomorrow if there are no objections. It is useful to run the testsuite on the installed gdb. e.g. make check RUNTESTFLAGS=GDB=/usr/bin/gdb When testing the installed gdb one would like to test exactly what the user runs. For environments that have a system.gdbinit (gdb was configured with --with-system-gdbinit) that means using the installed system.gdbinit and not anything from the source/build tree. In order to do this one either needs to not pass "-nx" when dejagnu starts gdb or pass "-x /path/to/system.gdbinit" in addition to -nx. I like the former as it's closer to what the user does. There is also the issue of not loading ~/.gdbinit when running the testsuite, but can be solved by pointing $HOME at a directory without a .gdbinit when running the testsuite. [-nx also skips loading of $pwd/.gdbinit, but the testsuite build directory generally doesn't have one and that's good enough for me for now] 2010-02-03 Doug Evans * gdb.exp (INTERNAL_GDBFLAGS): Don't override value provided by user. Index: gdb.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v retrieving revision 1.135 diff -u -p -r1.135 gdb.exp --- gdb.exp 14 Jan 2010 21:12:00 -0000 1.135 +++ gdb.exp 4 Feb 2010 00:15:25 -0000 @@ -54,7 +54,10 @@ if ![info exists GDBFLAGS] { verbose "using GDBFLAGS = $GDBFLAGS" 2 # INTERNAL_GDBFLAGS contains flags that the testsuite requires. -set INTERNAL_GDBFLAGS "-nw -nx" +global INTERNAL_GDBFLAGS +if ![info exists INTERNAL_GDBFLAGS] { + set INTERNAL_GDBFLAGS "-nw -nx" +} # The variable gdb_prompt is a regexp which matches the gdb prompt. # Set it if it is not already set.