From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29110 invoked by alias); 30 Jan 2010 14:47:42 -0000 Received: (qmail 29102 invoked by uid 22791); 30 Jan 2010 14:47:41 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 30 Jan 2010 14:47:30 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0UElSjc017634 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 30 Jan 2010 09:47:28 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0UElPAv008194 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 30 Jan 2010 09:47:27 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o0UElP89009947; Sat, 30 Jan 2010 15:47:25 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o0UElNb2009943; Sat, 30 Jan 2010 15:47:23 +0100 Date: Sat, 30 Jan 2010 14:47:00 -0000 From: Jan Kratochvil To: Mark Kettenis Cc: tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [patch] Do not disappoint on "Create a core file of GDB?" Message-ID: <20100130144723.GA9471@host0.dyn.jankratochvil.net> References: <20100111160241.GA12356@host0.dyn.jankratochvil.net> <20100115003529.GA26561@host0.dyn.jankratochvil.net> <201001301305.o0UD56Zp003815@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201001301305.o0UD56Zp003815@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00658.txt.bz2 On Sat, 30 Jan 2010 14:05:06 +0100, Mark Kettenis wrote: > I fear that after you did that the "NOTE: GDB has only three calls to > abort()." comment is no longer true. There were four calls and there are three calls now. The message has been updated: http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/utils.c.diff?cvsroot=src&r1=1.221&r2=1.222 + abort (); /* NOTE: GDB has only three calls to abort(). */ - abort (); /* NOTE: GDB has only four calls to abort(). */ + abort (); /* NOTE: GDB has only three calls to abort(). */ - abort (); /* NOTE: GDB has only four calls to abort(). */ + abort (); /* NOTE: GDB has only three calls to abort(). */ - abort (); /* NOTE: GDB has only four calls to abort(). */ - abort (); /* NOTE: GDB has only four calls to abort(). */ and current HEAD: $ grep 'GDB has only.*abort' * utils.c: abort (); /* NOTE: GDB has only three calls to abort(). */ utils.c: abort (); /* NOTE: GDB has only three calls to abort(). */ utils.c: abort (); /* NOTE: GDB has only three calls to abort(). */ The ChangeLog entry http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.11253&r2=1.11254 describes thise "four"->"three" word change by: (internal_vproblem): Update the comment. which may have been insufficient, sorry. Thanks, Jan