Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dan@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: Fix testsuite timeout clobbers
Date: Fri, 29 Jan 2010 15:37:00 -0000	[thread overview]
Message-ID: <20100129153726.GC30542@caradoc.them.org> (raw)
In-Reply-To: <20100129035950.GB26827@adacore.com>

On Fri, Jan 29, 2010 at 07:59:50AM +0400, Joel Brobecker wrote:
> Independently of that, do we want to try a different approache where
> the timeout gets reset more systematically? For instance, I can propose:
> everytime gdb_start is called, reset the timeout to the default value
> (which itself should be configurable - through a site.exp or board file?)

It sounds good - we'd have to audit everywhere that tests did set the
timeout, though, since if it ends up before gdb_start or there are
multiple calls to gdb_start, it'd get reset.  Does DejaGNU give us
a per-start-of-exp-file hook?

Meanwhile, I'll check this patch in now.

> On the same topic (timeouts), I ran the testsuite on sparc-solaris,
> yesterday, and some tests were badly timing out, and each timeout
> was taking what it felt like hours (the testsuite itself took more
> than 2 hours, and that's after I justed killed -9 the inferiors from
> the tests).  With AdaCore's testsuite, a timeout means we've lost sync
> with debugger anyway - is there really an advantage to continuing a
> testcase when we get a timeout? Wouldn't it just as effective to abort
> the testcase after the first timeout?

IMO this is an excellent idea.  I wonder if we shouldn't resurrect
(but, working this time!) the suppression mechanism?

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2010-01-29 15:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-28 21:53 Daniel Jacobowitz
2010-01-29  4:00 ` Joel Brobecker
2010-01-29 15:37   ` Daniel Jacobowitz [this message]
2010-02-04  6:08     ` [RFA/testsuite] Reset the timeout duration at the start of each testcase Joel Brobecker
2010-02-04 15:54       ` Tom Tromey
2010-02-04 16:00         ` Daniel Jacobowitz
2010-02-04 17:43           ` Joel Brobecker
2010-02-04 18:16             ` Daniel Jacobowitz
2010-02-05  7:22               ` Joel Brobecker
2010-02-05 17:33                 ` Daniel Jacobowitz
2010-02-08 11:36                   ` Joel Brobecker
2010-02-04  6:13     ` RFC: Fix testsuite timeout clobbers Joel Brobecker
2010-01-29 16:49   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100129153726.GC30542@caradoc.them.org \
    --to=dan@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox