From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [amd64-windows] Fix function calls on amd64-windows
Date: Fri, 29 Jan 2010 05:32:00 -0000 [thread overview]
Message-ID: <20100129053224.GF26827@adacore.com> (raw)
In-Reply-To: <20100125182821.GA32050@ednor.casa.cgf.cx>
> I don't believe that I am the maintainer of the x86_64 files but these
> changes look ok to me.
Thanks for the review - they are always appreciated, regardless of
is spending the time to look at the patch...
I have now checked in all the patches. Jan made a suggestion privately,
and I decided that it was simpler for me to do a follow up patch,
rather than redoing the patch. It's really minor and almost stylistic,
but a worthwhile suggestion nonetheless, so I will work on it asap.
--
Joel
next prev parent reply other threads:[~2010-01-29 5:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 5:42 Joel Brobecker
2010-01-25 5:42 ` [RFA/commit 1/3] amd64: Integer parameters in function calls on Windows Joel Brobecker
2010-01-25 5:42 ` [RFA/commit 3/3] amd64: 32 bytes allocated on stack by caller for integer parameter registers Joel Brobecker
2010-01-25 5:42 ` [RFA/commit 2/3] amd64-windows: memory args passed by pointer during function calls Joel Brobecker
2010-01-25 18:28 ` [amd64-windows] Fix function calls on amd64-windows Christopher Faylor
2010-01-29 5:32 ` Joel Brobecker [this message]
2010-01-30 19:26 ` Mark Kettenis
2010-01-31 5:35 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129053224.GF26827@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox