From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25119 invoked by alias); 29 Jan 2010 04:00:19 -0000 Received: (qmail 25107 invoked by uid 22791); 29 Jan 2010 04:00:18 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 29 Jan 2010 04:00:14 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B985D2BABDB for ; Thu, 28 Jan 2010 23:00:12 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id OhTNImB11Jpy for ; Thu, 28 Jan 2010 23:00:12 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 264502BABDA for ; Thu, 28 Jan 2010 23:00:12 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 770C2F59A0; Fri, 29 Jan 2010 07:59:50 +0400 (RET) Date: Fri, 29 Jan 2010 04:00:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: RFC: Fix testsuite timeout clobbers Message-ID: <20100129035950.GB26827@adacore.com> References: <20100128215305.GA2813@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100128215305.GA2813@caradoc.them.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00630.txt.bz2 > gdb/testsuite/ > * gdb.base/call-strs.exp, gdb.base/default.exp, > gdb.base/ending-run.exp, gdb.base/finish.exp, gdb.base/funcargs.exp, > gdb.base/huge.exp, gdb.base/nodebug.exp, gdb.base/ptype.exp, > gdb.base/restore.exp, gdb.base/return.exp, gdb.base/setvar.exp, > gdb.base/watchpoints.exp, gdb.threads/gcore-thread.exp, > gdb.base/watchpoint-solib.exp: Save and restore timeout. > * gdb.base/ending-run.exp: Correct restore of timeout. > * gdb.base/page.exp: Remove unnecessary timeout setting. Looks fine to me. Independently of that, do we want to try a different approache where the timeout gets reset more systematically? For instance, I can propose: everytime gdb_start is called, reset the timeout to the default value (which itself should be configurable - through a site.exp or board file?) On the same topic (timeouts), I ran the testsuite on sparc-solaris, yesterday, and some tests were badly timing out, and each timeout was taking what it felt like hours (the testsuite itself took more than 2 hours, and that's after I justed killed -9 the inferiors from the tests). With AdaCore's testsuite, a timeout means we've lost sync with debugger anyway - is there really an advantage to continuing a testcase when we get a timeout? Wouldn't it just as effective to abort the testcase after the first timeout? -- Joel