From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5845 invoked by alias); 28 Jan 2010 21:37:28 -0000 Received: (qmail 5831 invoked by uid 22791); 28 Jan 2010 21:37:27 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Jan 2010 21:37:13 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0SLbB9j021550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 28 Jan 2010 16:37:11 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0SLb8Tm013417 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 28 Jan 2010 16:37:10 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o0SLb8Y3031022; Thu, 28 Jan 2010 22:37:08 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o0SLb8f4031021; Thu, 28 Jan 2010 22:37:08 +0100 Date: Thu, 28 Jan 2010 21:37:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [patch] print a more useful error message for "gdb core" Message-ID: <20100128213708.GA30978@host0.dyn.jankratochvil.net> References: <20100120235605.607D284413@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="ibTvN161/egqYuK8" Content-Disposition: inline In-Reply-To: <20100120235605.607D284413@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00614.txt.bz2 --ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1048 Hi Doug, On Thu, 21 Jan 2010 00:56:05 +0100, Doug Evans wrote: > --- exec.c 19 Jan 2010 09:47:47 -0000 1.95 > +++ exec.c 20 Jan 2010 23:50:10 -0000 > @@ -253,6 +253,13 @@ exec_file_attach (char *filename, int fr > scratch_pathname = xstrdup (scratch_pathname); > cleanups = make_cleanup (xfree, scratch_pathname); > > + /* If the user accidentally did "gdb core", print a more useful > + error message. */ > + if (bfd_check_format (exec_bfd, bfd_core)) > + error (_("\"%s\" is a core file.\n" > + "Please specify an executable to debug."), > + scratch_pathname); > + > if (!bfd_check_format (exec_bfd, bfd_object)) > { > /* Make sure to close exec_bfd, or else "run" might try to use this patch has a regression with --enable-targets=all with i386-unknown-linux gnu native host as at least the attached i386 .so file gets identified as "trad-core" (and it gets no longer identified as bfd_object afterwards). One should try the bfd_core variant only if bfd_object has already failed. Regards, Jan --ibTvN161/egqYuK8 Content-Type: application/x-gzip Content-Disposition: attachment; filename="trad-core.so.gz" Content-Transfer-Encoding: base64 Content-length: 2802 H4sICLYCYksCA3RyYWQtY29yZS5zbwCdF21sXEdx3304dmyn19Y2obXag1rF Bvn1fEmMg4Rwcv5oimMH+1LFmHS5j2ffK/eR3ntnOVUk4l6oGo4ThuRHBAFS pVKNVKRUaUVokUh0FQ2qEKGEqlWRQIKWSxPSRCRgQZXHzO6+d3uPi4TY09zs zM7OzM7O7tv5+ujEmKIoXiKaF34K4BXgbAZ8cR3nbyZB4ie95F6ykY3L7Zif gx+JAGHjjNfJwQeMAECTGPcAOgXjpzo5nCcccNwn4KIEPQLssS+9ZyZJgybP 72BrIWR8cjep9j3wm/bsXw7M/PDdGz/6/Mv3DeofPItj6K9HzHtme9BPXhtu QV4zQCvy3j30z1f+/N0DkdHfX3n7iT3dT012pn5Wvr7h8u8+3OC2LcckCPAZ F71Tou8C6JboTwJ8AaAAjj/KxlvJtwCvdvHxALlu7Qd8XKIPuug5wG/A/F7A 98D8ANr12vZaCIoO+W26jRBKFzK5LDXMWN6klFA9q5uEzgOCocRSDLuxtP6k Rugji3RaW9ANU8tH0jHD0AyykC1Qfb6QTdB9eZCgyAU98zE9XRsjaT2eUY2c Ooi9BO9RLRkzYzAlbhjcOrCySTI+sWN7hIbVAXWT0w/ZEfKwrKz/eUiOpxNr xv16C+74dwQvoOvtOO8HYvyFTr6vSxCIJtisA4hh8w8ihritAF4H/KOIIW7H EAN/9+H3ZopXfFXUMbdc2XM3IaUjNyzL+sabpr96H3Cr7+DfSzB3z9yvKtZp zD7rZLOwa52EWJMUdi/9CaZZJ9G7FA5fusBozNQUMi+dBRLsPTpT/QWQy5UP IFHKyZ5rB1/diPMLXykVP0LLZ80N5WIv9A77eqqvAi6fDuL/kW7473urVMTk OnfLU7yqbL1m3L9SNh8kxbPKYca3jhZRjAttvZZ//5dF1K6AocDcY3srl9tX 5Ibrr4aYO3PcnSulIz18/Z2l4hr3p7XMeIc7eqwLINIxt7dS6u6p8Pln0Pm9 FeiVRpvBD9aFoHZU34Y5yxUv6C0V8ZCApk+Xi54PQdNIT9vrIz3NnwJuuXjh KuP4ysXLV/mqX75lWa+zOXjwiq+hRdBaRc7yuRfvBI3LXGOhubz8h79Z1uWm 8vL7gMGzNuaZsz6I9xRz5EmcVuyAPqzL/Hj5NHbLLz2I/pcXP7IulJpgoHAD w+TKi2GYWh0Gp2YhB9SHFpJxNR4ztIfgLPSzs9APJ0BNkE/UDg4eOJ2dsKTr OLG8gSZjO4dxuZpYNuZ/mzjn7eJ837xl5dbE3bYm7twhwOsBPy/utYC4Gw91 8ftvo7gvYQ3kY3j/eXm/6uF3FQbybnEvwhJzZzzMrxz6cA3wCaD/Jej/p+E3 wG7zYHsR4GmA8Ujkc8FeuMH7gpvVzWo4GA6Ftg6Ew+Fg77SWDD4cMzm/Pxzq cwtvAuGBUGggPFAvvKk/3EeIauzPmLE4YDPPccruZXOmpsJ+qPGCnk7260nC qFTMSBE1uT8LMzk283xkUcsbei5bR1AYy2tplOOdfWmTqOyKVU1tCf7ZRavm c+wyVLUUnc/HMhpRE2Yub4ABjh5PgCIUYUryOWY5ltETYC1nsj+uGi5TmJvL ZLSs+T/H/V6AdeIbKH9r7eYTWAX4B+wvyq0JGBY5RKRv7pDIL4/IOYSzYkwR OCDN9YgcRXi+wbf0YZ7/zC7mGMJGya5HwG6Rl9jH3EQIuexiw0dDi5iDuY0Q dK0DczwjyeFZQLDtrpfkFoX+JnEGEUIN4veEJLfLy2HYJYdwQJLD9xfCqnSo 7G/dU5IcnnmE7gZ2nxFyuI6on8NwgzivSHJH/Rx8DfR9T8hhHNjbzs/j4JZ7 VpI7AXInbiO3Ksmtgtzqbez+RJLDO/CF28i9ImLiFXcKvjHPS+P2vlUkffge WGri96h7P85LcnhXHmrieeCW+63Q6xVvsuMN9GF7S+izcwTlZl37oYh72Cvx b4LcHxvsm71ndmsDo6e8+P6r5X9A5LKs7+d3EPJvpfHb1d0uOnUBl1pzaG55 SKnVDUScZ07zVZ/w2DR/fJ5xaFYNsDPIaV5oNHttmmdM0KFbGN7l0Ot57jp0 K/fHb9N8B6IO3c7wUYfmT/hjnTZ9B/fXoflpW3XoO51vMKfvqvt2edkXkucT pzsYPuTQXPC4Q3fVxdkLX16lLmeuW22Sfwr4d4/knwL+9Ur+KeDfFikeHojH F4U9nldd5Ms4v8u+F7vYqzToq8m77eOX5Lhkf1mKnwLx+7bL/veJeHgIfS+6 9J0D/FUfv0Nx/A3Aj/vsb0YrO0fPSf79FfDToG8Do9vZQux4KqCvS6nthwL7 8QDQz0nxCQH9d2l940DPSvRjSm3/UN+CUl+zLbrobyr1NdSKUl/T/Vipr+F+ qtTXaBWlvkb7tVJf473pkn9Hqa8Rbyr1NR1J5E3DLMzPw8OS0kh0appO7JiJ YjVHR+qoRyISkczRhXQuHktT9sqgscISgafDvrRmakl1y9YtWwgOUD25hNRn CXua0GQhk9lv2xmdHGG6xqa37Rx1KDRj92tWEo4V92sYH0RQAxbihBWbpPHj mNJd06PR6Cwd2z0Zie6YmqRUHQgPDhA6PjG1fdsEnRobmxmN0ui27ROjzLSR o6lYNpnW7EDYTumDQ4PqgmbSfQlqpgrZr6mJpYbsOLBHZie37dwR+a9KuUE5 bNfNUhk8PFyrYt3Vcq30rdXKrAh2imO5AK9pwtqYF+r/ATBqu9C3EQAA --ibTvN161/egqYuK8--