From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch] Comment symbol->symtab NULL [Re: [patch] Fix solib-display.exp crash]
Date: Tue, 26 Jan 2010 23:52:00 -0000 [thread overview]
Message-ID: <20100126235016.GA31019@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20100126212425.GB17877@caradoc.them.org>
On Tue, 26 Jan 2010 22:24:25 +0100, Daniel Jacobowitz wrote:
> On Wed, Jan 20, 2010 at 12:40:01AM +0100, Jan Kratochvil wrote:
> > The question is whether SYMBOL_SYMTAB (symbol) can be ever NULL at this point.
> > IMO not, it can be NULL only temporarily during reading symbols.
>
> I think that's right; this patch is fine. Thanks!
Checked-in:
http://sourceware.org/ml/gdb-cvs/2010-01/msg00217.html
OK to check-in this comment?
Thanks,
Jan
2010-01-27 Jan Kratochvil <jan.kratochvil@redhat.com>
* symtab.h (struct symbol <symtab>): New comment on NULL values.
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -554,7 +554,8 @@ struct symbol
struct type *type;
/* The symbol table containing this symbol. This is the file
- associated with LINE. */
+ associated with LINE. It can be NULL during symbols read-in but it is
+ never NULL during normal operation. */
struct symtab *symtab;
/* Domain code. */
next prev parent reply other threads:[~2010-01-26 23:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 23:40 [patch] Fix solib-display.exp crash Jan Kratochvil
2010-01-26 21:24 ` Daniel Jacobowitz
2010-01-26 23:52 ` Jan Kratochvil [this message]
2010-01-27 0:06 ` [patch] Comment symbol->symtab NULL [Re: [patch] Fix solib-display.exp crash] Daniel Jacobowitz
2010-01-27 0:16 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100126235016.GA31019@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox