From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30568 invoked by alias); 26 Jan 2010 21:58:59 -0000 Received: (qmail 30560 invoked by uid 22791); 26 Jan 2010 21:58:58 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Jan 2010 21:58:53 +0000 Received: (qmail 21355 invoked from network); 26 Jan 2010 21:58:52 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Jan 2010 21:58:52 -0000 Date: Tue, 26 Jan 2010 21:58:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [1/4] RFC: refactor partial symbol tables Message-ID: <20100126215846.GA21107@caradoc.them.org> Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: <20100126214550.GD17877@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00584.txt.bz2 On Tue, Jan 26, 2010 at 02:54:21PM -0700, Tom Tromey wrote: > I did consider this, and I (safely) punted. > > On my branch, the only non-psymtab implementation of the quick API is in > dwarf2read.c, and that code bails out and reverts to using psymtabs if > it find that any other reader has created psymtabs for the objfile. Good enough for me (assuming you've thought about the ordering issues and it bails out late enough?). I don't see any reason not to go with your patches, although at this point post-7.1 may be appropriate. -- Daniel Jacobowitz CodeSourcery