From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25760 invoked by alias); 26 Jan 2010 21:45:58 -0000 Received: (qmail 25751 invoked by uid 22791); 26 Jan 2010 21:45:57 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Jan 2010 21:45:54 +0000 Received: (qmail 13356 invoked from network); 26 Jan 2010 21:45:53 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Jan 2010 21:45:53 -0000 Date: Tue, 26 Jan 2010 21:45:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [1/4] RFC: refactor partial symbol tables Message-ID: <20100126214550.GD17877@caradoc.them.org> Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00582.txt.bz2 On Fri, Jan 15, 2010 at 05:25:18PM -0700, Tom Tromey wrote: > This patch does the bulk of the work. > > I went through gdb and looked at all uses of partial symbol tables. I > moved all the psymtab code into a new file, and changed all the code in > gdb to call via a new struct of function pointers. Overall, I very much like this series and think it should go in. Have you considered the case of objfiles with multiple formats of debug info? This used to be a very common case, where the system libraries had some stabs data and the user code had dwarf-2. It's probably still happening on various platforms. So it seems like we need to be able to query multiple symbol readers' qf functions, potentially. -- Daniel Jacobowitz CodeSourcery