From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Cc: Paul Pluzhnikov <ppluzhnikov@google.com>
Subject: [obv] testsuite: Fix gdb.arch/i386-bp_permanent.exp regression
Date: Sun, 24 Jan 2010 04:33:00 -0000 [thread overview]
Message-ID: <20100124043257.GA17793@host0.dyn.jankratochvil.net> (raw)
Hi,
fixed
Running ./gdb.arch/i386-bp_permanent.exp ...
-FAIL: gdb.arch/i386-bp_permanent.exp: Disassemble function 'standard'
-FAIL: gdb.arch/i386-bp_permanent.exp: Disassemble failed, skipping entire test.
+PASS: gdb.arch/i386-bp_permanent.exp: Stop at the 'standard' start breakpoint (fetching esp).
+PASS: gdb.arch/i386-bp_permanent.exp: Stop at permanent breakpoint.
+PASS: gdb.arch/i386-bp_permanent.exp: Single stepping past permanent breakpoint.
+PASS: gdb.arch/i386-bp_permanent.exp: ESP value does not match - step_permanent_breakpoint wrong.
due to
[patch] Omit function name when disassembling one function [Was: Re: [RFC][patch] Allow to disassemble line.]
http://sourceware.org/ml/gdb-patches/2009-10/msg00505.html
http://sourceware.org/ml/gdb-cvs/2009-10/msg00161.html
according to the approved adjustment there:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.asm/asm-source.exp.diff?cvsroot=src&r1=1.74&r2=1.75
Regards,
Jan
http://sourceware.org/ml/gdb-cvs/2010-01/msg00203.html
--- src/gdb/testsuite/ChangeLog 2010/01/22 17:06:49 1.2099
+++ src/gdb/testsuite/ChangeLog 2010/01/24 04:29:32 1.2100
@@ -1,3 +1,8 @@
+2010-01-24 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * gdb.arch/i386-bp_permanent.exp (Disassemble function '$function'):
+ Adjust it for DISASSEMBLY_OMIT_FNAME.
+
2010-01-22 Jan Kratochvil <jan.kratochvil@redhat.com>
PR symtab/11199:
--- src/gdb/testsuite/gdb.arch/i386-bp_permanent.exp 2010/01/01 07:32:00 1.3
+++ src/gdb/testsuite/gdb.arch/i386-bp_permanent.exp 2010/01/24 04:29:32 1.4
@@ -62,7 +62,7 @@
set function standard
set retcode [gdb_test_multiple "disassemble $function" "Disassemble function '$function'" {
- -re ".*($hex) <$function\\+0>.*($hex) <$function\\+4>.*($hex) <$function\\+5>.*($hex) <$function\\+6>.*$gdb_prompt $" {
+ -re ".*($hex) <\\+0>.*($hex) <\\+4>.*($hex) <\\+5>.*($hex) <\\+6>.*$gdb_prompt $" {
set function_start $expect_out(1,string);
set address $expect_out(2,string);
set address1 $expect_out(3,string);
next reply other threads:[~2010-01-24 4:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-24 4:33 Jan Kratochvil [this message]
2010-01-24 4:42 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100124043257.GA17793@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox