From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Cc: Pedro Alves <pedro@codesourcery.com>
Subject: [obv] [s390] gdbserver regcache compilation fix
Date: Thu, 21 Jan 2010 19:29:00 -0000 [thread overview]
Message-ID: <20100121192852.GA18915@host0.dyn.jankratochvil.net> (raw)
Hi Pedro,
checked-in this one as [obv] althought remains IMO-non-obv ppc:
linux-ppc-low.c: In function ‘ppc_arch_setup’:
linux-ppc-low.c:347: warning: passing argument 1 of ‘collect_register_by_name’ from incompatible pointer type
linux-ppc-low.c:347: warning: passing argument 2 of ‘collect_register_by_name’ from incompatible pointer type
linux-ppc-low.c:347: error: too few arguments to function ‘collect_register_by_name’
Thanks,
Jan
http://sourceware.org/ml/gdb-cvs/2010-01/msg00193.html
--- src/gdb/gdbserver/ChangeLog 2010/01/21 18:35:42 1.324
+++ src/gdb/gdbserver/ChangeLog 2010/01/21 19:26:49 1.325
@@ -1,3 +1,8 @@
+2010-01-21 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * linux-s390-low.c (s390_collect_ptrace_register)
+ (s390_supply_ptrace_register): Adjust it for the new regcache parameter.
+
2010-01-21 Doug Evans <dje@google.com>
* linux-low.c (PTRACE_ARG3_TYPE): Change from long to void*.
--- src/gdb/gdbserver/linux-s390-low.c 2010/01/20 22:55:38 1.19
+++ src/gdb/gdbserver/linux-s390-low.c 2010/01/21 19:26:49 1.20
@@ -118,8 +118,9 @@
if ((regno ^ 1) < the_low_target.num_regs
&& the_low_target.regmap[regno ^ 1] == regaddr)
{
- collect_register (regno & ~1, buf);
- collect_register ((regno & ~1) + 1, buf + sizeof (long) - size);
+ collect_register (regcache, regno & ~1, buf);
+ collect_register (regcache, (regno & ~1) + 1,
+ buf + sizeof (long) - size);
}
else if (regaddr == PT_PSWADDR
|| (regaddr >= PT_GPR0 && regaddr <= PT_GPR15))
@@ -133,7 +134,7 @@
buf[size] |= 0x80;
}
else
- collect_register (regno, buf);
+ collect_register (regcache, regno, buf);
}
static void
@@ -147,8 +148,9 @@
if ((regno ^ 1) < the_low_target.num_regs
&& the_low_target.regmap[regno ^ 1] == regaddr)
{
- supply_register (regno & ~1, buf);
- supply_register ((regno & ~1) + 1, buf + sizeof (long) - size);
+ supply_register (regcache, regno & ~1, buf);
+ supply_register (regcache, (regno & ~1) + 1,
+ buf + sizeof (long) - size);
}
else if (regaddr == PT_PSWADDR
|| (regaddr >= PT_GPR0 && regaddr <= PT_GPR15))
next reply other threads:[~2010-01-21 19:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 19:29 Jan Kratochvil [this message]
2010-01-21 22:21 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121192852.GA18915@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox