From: Vladimir Prus <vladimir@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Per-inferior program arguments and io terminal
Date: Wed, 20 Jan 2010 14:23:00 -0000 [thread overview]
Message-ID: <201001201723.31137.vladimir@codesourcery.com> (raw)
In-Reply-To: <201001200614.26747.pedro@codesourcery.com>
On Wednesday 20 January 2010 09:14:26 Pedro Alves wrote:
> On Tuesday 19 January 2010 21:53:23, Vladimir Prus wrote:
>
> > Per-inferior args and tty and environment.
> >
> > * infcmd.c (inferior_args): Rename to ...
> > (inferior_args_scratch): ... this.
> > (inferior_io_terminal): Rename to ...
> > (inferior_io_terminal_scratch): ... this.
> > (inferior_argc, inferior_argv): Remove.
> > (set_inferior_io_terminal, get_inferior_io_terminal): Store
> > inside current_inferior().
> > (set_inferior_tty_command, show_inferior_tty_command): New.
> > (get_inferior_args, set_inferior_args): Store inside
> > current_inferior().
> > (notice_args_set): Likewise and rename to...
> > (set_args_command): ... this.
> > (set_inferior_args_vector): Likewise.
> > (notice_args_read): Rename to...
> > (show_args_command): ...new.
> > (tty_command): Remove.
> > (run_command_1): Don't free old args, as they are freed by
> > set_inferior_arg now.
> > (run_no_args_command): Likewise.
> > (inferior_environ): Remove.
> > (run_command_1): Use environemnt of the current inferior.
>
> Typo: "environemnt"
>
> > (environment_info, set_environment_command)
> > (unset_environment_command, path_info, path_command): Likewise.
> > (_initialize_infcmd): Adjust for function and variable renames.
> > Do not init inferior_environ.
> > * inferior.h (set_inferior_arg): Adjust prototype.
> > (struct inferior): New fields args, argc, argv, terminal, environment.
> > (inferior_environ): Remove declaration.
> > * inferior.c (free_inferior): Free new fields.
> > (add_inferior_silent): Initialize 'environment' field.
> > * main.c (captured_main): Set arguments only after the initial
> > inferior has been created. Set set_inferior_io_terminal,
> > not tty_command.
> > * mi/mi-main.c (mi_cmd_env_path): Use environment of the current
> > inferior.
> > (_initialize_mi_cmd_env): Adjust for disappearance of global
> > inferior_environ.
> > * solib.c (solib_find): Use environment of the current inferior.
>
> This version is OK. Thanks.
Thanks, checked in.
- Volodya
prev parent reply other threads:[~2010-01-20 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 12:44 Vladimir Prus
2010-01-13 15:49 ` Pedro Alves
2010-01-14 9:27 ` Vladimir Prus
2010-01-14 13:38 ` Pedro Alves
2010-01-14 15:09 ` Vladimir Prus
2010-01-14 15:49 ` Pedro Alves
2010-01-19 21:53 ` Vladimir Prus
2010-01-20 6:14 ` Pedro Alves
2010-01-20 14:23 ` Vladimir Prus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001201723.31137.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox