From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31566 invoked by alias); 19 Jan 2010 23:53:33 -0000 Received: (qmail 31556 invoked by uid 22791); 19 Jan 2010 23:53:33 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Jan 2010 23:53:25 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0JNrOIN023638 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Jan 2010 18:53:24 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0JNrLIo022039 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 19 Jan 2010 18:53:23 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o0JNrLwu009556 for ; Wed, 20 Jan 2010 00:53:21 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o0JNrKDx009555 for gdb-patches@sourceware.org; Wed, 20 Jan 2010 00:53:20 +0100 Date: Tue, 19 Jan 2010 23:53:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [patch] remove some unused python functions Message-ID: <20100119235320.GA9480@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00486.txt.bz2 Hi, with --without-python: cc1: warnings being treated as errors varobj.c:765: error: ‘instantiate_pretty_printer’ defined but not used varobj.c:906: error: ‘install_dynamic_child’ defined but not used Thanks, Jan 2010-01-20 Jan Kratochvil * varobj.c (varobj_add_child, install_dynamic_child): Wrap into #if HAVE_PYTHON. (instantiate_pretty_printer): Move HAVE_PYTHON outside of the function. --- a/gdb/varobj.c +++ b/gdb/varobj.c @@ -293,9 +293,13 @@ static int varobj_value_is_changeable_p (struct varobj *var); static int is_root_p (struct varobj *var); +#if HAVE_PYTHON + static struct varobj * varobj_add_child (struct varobj *var, const char *name, struct value *value); +#endif /* HAVE_PYTHON */ + /* C implementation */ static int c_number_of_children (struct varobj *var); @@ -759,12 +763,13 @@ varobj_delete (struct varobj *var, char ***dellist, int only_children) return delcount; } +#if HAVE_PYTHON + /* Convenience function for varobj_set_visualizer. Instantiate a pretty-printer for a given value. */ static PyObject * instantiate_pretty_printer (PyObject *constructor, struct value *value) { -#if HAVE_PYTHON PyObject *val_obj = NULL; PyObject *printer; @@ -775,10 +780,11 @@ instantiate_pretty_printer (PyObject *constructor, struct value *value) printer = PyObject_CallFunctionObjArgs (constructor, val_obj, NULL); Py_DECREF (val_obj); return printer; -#endif return NULL; } +#endif + /* Set/Get variable object display format */ enum varobj_display_formats @@ -899,6 +905,8 @@ restrict_range (VEC (varobj_p) *children, int *from, int *to) } } +#if HAVE_PYTHON + /* A helper for update_dynamic_varobj_children that installs a new child when needed. */ @@ -935,8 +943,6 @@ install_dynamic_child (struct varobj *var, } } -#if HAVE_PYTHON - static int dynamic_varobj_has_child_method (struct varobj *var) { @@ -1158,6 +1164,8 @@ varobj_list_children (struct varobj *var, int *from, int *to) return var->children; } +#if HAVE_PYTHON + static struct varobj * varobj_add_child (struct varobj *var, const char *name, struct value *value) { @@ -1168,6 +1176,8 @@ varobj_add_child (struct varobj *var, const char *name, struct value *value) return v; } +#endif /* HAVE_PYTHON */ + /* Obtain the type of an object Variable as a string similar to the one gdb prints on the console */